Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; the previous testing gap is addressed. SummaryAdds AMD GPU details to
All 24 focused checks passed. Bash syntax checks and Reviews (2) · Last reviewed commit: "Cover AMD debug collector guards with PC..." · Reviewed by Greptile |
|
Reviewed at e73b47d. The collector works as described and its tests pass, but the change is a good deal larger than what it adds to a debug report, and its runtime-PM guard defends against a GPU wake that current kernels already refuse. Nothing was pushed; this waits on the author for a smaller version, and on the maintainer for whether they want the section at all. What ran, and where. On a disposable Omarchy worker (QEMU, virtio GPU, kernel 7.2.8): Proportionality. The report already runs The runtime-PM guard (bin/omarchy-debug:84-92). On a kernel Omarchy ships, none of these reads wakes the device. In upstream amdgpu, Smaller points. The section header appears at the top of every report, including on Intel and NVIDIA machines, where it says only that there is no AMD controller. Printing nothing when no AMD GPU is found would avoid that. Second opinion. Codex Medium reviewed the same head. Separately from this review, it traced the kernel handlers above and pointed out that the guard hides readable memory pools on a suspended dGPU. I confirmed both against the upstream amdgpu source before including them. On proportionality and the inxi overlap it agreed with conclusions I had already reached, and that agreement is not guaranteed to be independent. It found no stderr, heredoc or empty-glob defect, and neither did I. |
Summary
Add an AMD GPU section to
omarchy debug, reporting cached PCI identity, bound driver, runtime state, GPU activity, and separate VRAM/GTT allocation and capacity counters.1002and class03, including Display-class038000APUs and multiple GPUs. No fixed DRM card index or loaded-module predicate.amdgpudevices with runtime stateactiveorunsupported. Skip suspended, transitional, or unavailable states.inxi, so it records runtime state before that broader scan.Memory counts are printed in bytes. VRAM and GTT remain separate driver pools, with a note about their relationship to system RAM accounting. This is a diagnostic enhancement.
Native execution
Ran the complete
bin/omarchy-debug --no-sudo --printcommand on an HP ZBook Ultra G1a with Ryzen AI Max+ PRO 395 / Radeon 8060S. It exited 0 in approximately 1.2 seconds with no stderr output.The pool values matched a subsequent native sysfs read; GPU activity changed from 4% to 5% between samples, as expected for a live counter. The capacities are 512 MiB VRAM and about 62.53 GiB GTT. The DRM node on this machine is
card1.Checks and limits
bash -n bin/omarchy-debug: passed.git diff --check: passed.bin/omarchy debug --help: resolves to the existing command and flags.bash test/shell.d/debug-amd-gpu-test.sh: 24/24 fixture checks passed.No full system report or journal output is attached; the excerpt contains the AMD section only.
Fixture coverage follow-up
Test-only commit
e73b47ddaddstest/shell.d/debug-amd-gpu-test.sh, picked up by the existing shell test runner. The production collector is unchanged.The suite loads the real collector functions and uses temporary
OMARCHY_PCI_DEVICES_PATHfixtures without running unrelated whole-system probes or writing the full debug log. Coverage includes:038000, VGA, and 3D controllers; active and unsupported runtime PM.Focused run: 24 checks passed, 0 failed, approximately 1.3 seconds. Bash syntax and whitespace checks also pass. The complete CLI/shell aggregate suites were not run for this test-only follow-up.