Skip to content

Detect the FocalTech power-button reader by vendor:product - #16228

Open
atwardowski wants to merge 1 commit into
omacom:quattrofrom
atwardowski:focaltech-fingerprint-detection
Open

atwardowski wants to merge 1 commit into
omacom:quattrofrom
atwardowski:focaltech-fingerprint-detection

Conversation

@atwardowski

Copy link
Copy Markdown

Problem

On a Framework Laptop 12, `omarchy setup security fingerprint` reports
"No fingerprint sensor detected" even though the laptop's built-in reader
(in the power button) is present and working.

The reader enumerates as `2808:079a` with the product string
"\"FocalTech FT9769DL ESS\"" and no kernel driver bound to its
interface — the correct libusb/reader signature. It matches nothing in
`omarchy-hw-fingerprint`: the product string names neither the function
nor the vendor, and FocalTech's vendor ID is deliberately absent from the
vendor list because FocalTech also makes touchscreens.

Fix

Add a vendor:product match (`2808:079a`) in `bin/omarchy-hw-fingerprint`.
The pair is pinned rather than added to the vendor list, and it keeps the
same no-kernel-driver requirement the vendor list carries, so a same-vendor
FocalTech touchscreen that binds usbhid is still rejected.

Tests

  • `test/shell.d/hw-fingerprint-test.sh`: two new cases — the pair is
    detected, and the same pair with a kernel driver bound is rejected.
    Full test file passes (25/25).
  • Verified on the affected hardware: the patched detector exits 0 on a
    Framework Laptop 12, and the full setup wizard then enrolled, verified,
    and configured PAM for the built-in reader end to end.

The Framework Laptop 12's reader in the power button reports
"FocalTech FT9769DL ESS", naming neither the function nor the vendor,
and FocalTech also makes touchscreens, so the bare vendor ID cannot go
in the vendor list. Pin the 2808:079a pair with the same
no-kernel-driver requirement the vendor list carries, keeping a
same-vendor touchscreen that binds usbhid rejected.
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds detection for the Framework Laptop 12’s FocalTech fingerprint reader by its USB pair, 2808:079a.

  • Fingerprint detection recognizes the Framework Laptop 12’s FocalTech power-button reader.

No actionable issues found. Tests were inspected but not run.

Reviews (1) · Last reviewed commit: "Detect the FocalTech power-button reader..." · Reviewed by Greptile

@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 22, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for tracking this down on the Framework Laptop 12, and for confirming the reader enrolls end to end once it is detected.

This is one of three open pull requests fixing the same cause: FocalTech readers name neither the function nor a known vendor in their product string, and 2808 is not in fingerprint_vendors. The other two are #11387 (opened 2026-09-11) and #15586, which both add 2808 to the vendor list and rely on the same no-kernel-driver check this one keeps. #11387 is the oldest, and it also covers this reader: on this pull request's own premise that 2808:079a binds no kernel driver, the vendor match accepts it. It also covers the other FocalTech readers reported so far (2808:a57a in #15563, 2808:a97a in #14089, 2808:a658 in #8800), which a single pinned pair leaves undetected.

On the touchscreen concern: FocalTech's USB touch controllers bind usbhid and are rejected by has_kernel_driver, the same guard that already keeps Synaptics touchpads and webcam bridges out. Neither of us found a FocalTech USB device that normally runs with no kernel driver bound and is not a reader, so the pair does not buy safety the vendor match lacks.

What was checked: the diff, the detector and its tests at 8115cda6, and the competing pull requests' diffs, all by reading. Nothing was run on a worker, because a fix that will not be the one merged is not worth a worker. The comparison was reviewed by Codex Medium and muse-spark-1.3 (thinking high). Both picked #11387 for the same reason, and both found no defect in this change for the reader it targets. They read the same brief I wrote, so their agreement is not a guaranteed independent check.

This waits on the maintainer, who chooses between the competing fixes. If #11387 lands, this one can be closed.

@chessing234 chessing234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants