Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "Dismiss screensaver on modifier keys and..." · Reviewed by Greptile |
This was referenced Oct 23, 2026
Open
Collaborator
|
Thanks for working on this. #16800, now merged, replaced the terminal screensaver with a native Wayland overlay that dismisses itself on any key, click, scroll or mouse movement, so this fix to the terminal version is no longer needed. Closing in favour of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow modifier-only key presses and mouse or trackpad movement to dismiss the screensaver in supporting terminals.
The existing
read -n1loop receives ordinary keystrokes, but modifier-only presses and pointer movement normally produce no terminal input. This pull request enables Kitty's report-all-keys mode and all-motion mouse reporting with SGR pixel coordinates so those events also reach the input loop.Details
IFS= read -r -s -n1 -t 1to consume input without whitespace trimming, backslash interpretation, or echoing.Testing
Run
omarchy-launch-screensaverWhile the screensaver is active, press a modifier key (Shift, Ctrl, Cmd, Option), or move the mouse
Expected results: screensaver closes
References
Related discussion shows this is a desired feature: #5592