Skip to content

Dismiss screensaver on modifier keys and pointer movement - #16235

Closed
3j27 wants to merge 1 commit into
omacom:quattrofrom
3j27:codex/screensaver-input
Closed

3j27 wants to merge 1 commit into
omacom:quattrofrom
3j27:codex/screensaver-input

Conversation

@3j27

@3j27 3j27 commented Oct 22, 2026

Copy link
Copy Markdown

Allow modifier-only key presses and mouse or trackpad movement to dismiss the screensaver in supporting terminals.

The existing read -n1 loop receives ordinary keystrokes, but modifier-only presses and pointer movement normally produce no terminal input. This pull request enables Kitty's report-all-keys mode and all-motion mouse reporting with SGR pixel coordinates so those events also reach the input loop.

Details

  • Saves the terminal settings and disables echo and canonical input while the screensaver runs.
  • Enables extended keyboard reporting, including modifier-only keys, and mouse reporting for pointer movement without requiring a click.
  • Uses IFS= read -r -s -n1 -t 1 to consume input without whitespace trimming, backslash interpretation, or echoing.
  • Disables reporting and restores terminal settings before closing the screensaver terminal. An EXIT trap also handles other shell exits.
  • Leaves focus reporting disabled so startup focus changes do not immediately dismiss the screensaver.

Testing

Run omarchy-launch-screensaver
While the screensaver is active, press a modifier key (Shift, Ctrl, Cmd, Option), or move the mouse

Expected results: screensaver closes

References

Related discussion shows this is a desired feature: #5592

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates omarchy-screensaver so modifier-only key presses and pointer movement can dismiss it in supporting terminals.

  • Modifier keys and pointer movement can now dismiss the screensaver.

Reviews (1) · Last reviewed commit: "Dismiss screensaver on modifier keys and..." · Reviewed by Greptile

@omarchybot omarchybot added the enhancement New feature or request label Oct 22, 2026

@chessing234 chessing234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for working on this. #16800, now merged, replaced the terminal screensaver with a native Wayland overlay that dismisses itself on any key, click, scroll or mouse movement, so this fix to the terminal version is no longer needed. Closing in favour of it.

@omarchybot omarchybot closed this Oct 28, 2026
@3j27
3j27 deleted the codex/screensaver-input branch October 29, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants