Repository navigation
Conversation
systemd 262 failed systemd-tpm2-setup-early, systemd-pcrproduct and systemd-pcrlogin@ on every boot from a UKI without a signed PCR policy, which is every Omarchy UKI (systemd/systemd#43848, #15813). #14820 accepted their exit status 1 until systemd shipped the fix. systemd 262.1 ships it (systemd/systemd#43948), and every channel now serves 262.1-1, on both x86_64 and aarch64. The drop-ins now only hide real failures: with SuccessExitStatus=1 a TPM that stops answering looks like a successful unit. On an MSI Z690 with Intel PTT, systemd 262.1-1 and a Limine UKI, booted with the three drop-ins moved aside: systemd-tpm2-setup-early skipped the four NvPCRs and exited 78, which its own SuccessExitStatus accepts. systemd-pcrproduct and systemd-pcrlogin@1000 logged "not initialized, skipping gracefully" and exited 0. No unit failed.
[Medium impact] The PR appears safe to merge. SummaryRemoves three temporary systemd drop-ins that treated exit status 1 as success.
Reviews (1) · Last reviewed commit: "Remove the NvPCR drop-ins now that syste..." · Reviewed by Greptile |
|
Reviewed at 72a4b5c. Nothing wrong in the diff. It waits on a TPM machine confirming it, because the worker it ran on has no TPM. What was checked:
Second opinion: Codex Medium and muse-spark-1.3-contributor (via pi, thinking high) read the same change. Neither found a defect in this repository. They may have read this review's notes, so their agreement is not independent. Codex traced the v262.1 exit paths above, and they hold against the source. It also pointed out that a machine whose What is not proven yet is a boot with a TPM. @GIDEMA-VPL, you reported this in #15813. If you can, please run the check below on that machine. With systemd 262.1-1 installed, this head is equivalent to removing the three files: pacman -Q systemd # 262.1-1 or later
sudo mkdir -p /root/nvpcr-aside
for u in systemd-tpm2-setup-early.service systemd-pcrproduct.service systemd-pcrlogin@.service; do sudo mv "/usr/lib/systemd/system/$u.d/10-omarchy-nvpcr.conf" "/root/nvpcr-aside/$u.conf"; done
sudo systemctl daemon-reload && systemctl rebootAfter the reboot: systemctl --failed
systemctl show -p Result,ExecMainStatus systemd-tpm2-setup-early.service systemd-pcrproduct.service "systemd-pcrlogin@$(id -u).service"Then put the files back with |
|
Confirmed on a TPM machine: MSI Z690 with Intel PTT, systemd 262.1-1, booted with and without the three drop-ins. |
|
Thanks, @emirb. Your MSI Z690 boot matches what the worker showed and what systemd v262.1's source says: That still leaves |
chessing234
left a comment
There was a problem hiding this comment.
these drop-ins are what keep systemd-pcr* from failing the boot when the uki has no pcr policy. deleting them with no check that systemd is actually >= 262.1 puts every machine still on 262.0 back on the failing units. gate the removal on the running systemd version.
|
@chessing234, the risk you describe is real, but only for a narrower set of machines, and the fix you suggest can't live in this pull request. What was checked, against
Who checked: Claude Opus 5.5 read the update scripts. Codex Medium reviewed your comment separately and reached the same conclusion, and it found the This still waits on the maintainer: whether the author's TPM boot is enough, and whether #1472 should add the dependency. |
systemd 262 failed
systemd-tpm2-setup-early,systemd-pcrproductandsystemd-pcrlogin@on every boot from a UKI without a signed PCR policy (systemd/systemd#43848). That is every Omarchy UKI. #14820 added drop-ins that accept their exit status 1 until systemd shipped the fix. systemd 262.1 has it (systemd/systemd#43948), and stable, rc and edge serve 262.1-1 on x86_64 and aarch64. The drop-ins now only hide real failures: a TPM that stops answering also exits 1, and the unit reports success.On an MSI Z690 with Intel PTT, booted with the three drop-ins moved aside:
systemd-tpm2-setup-earlyskipped the four NvPCRs and exited 78, which its own unit accepts;systemd-pcrproductandsystemd-pcrlogin@1000exited 0 with "not initialized, skipping gracefully";omarchy-settings stops installing the files in omacom/omarchy-pkgs#1472; either PR can merge first.
Refs #15813, #14820