Repository navigation
Conversation
omp and pi both move their whole agent tree when PI_CODING_AGENT_DIR is set: omp honors the variable itself. The Antigravity collector already looks for pi's auth.json there, but its omp database was read from ~/.omp/agent alone, so a moved sign-in went unseen and the panel showed no plan or limits for an account that was signed in. The database is now looked for where the variable points, as pi's is, and the harness test covers it the same way pi's case does, including that the store is never written to.
…n PI_CODING_AGENT_DIR is set Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
 [Medium impact] The PR appears safe to merge. SummaryThe Antigravity collector now reads
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "Say where the Antigravity collector find..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omp moves its whole agent tree when
PI_CODING_AGENT_DIRis set; it honors the variable itself, which is easy to see:PI_CODING_AGENT_DIR=/tmp/x omp usagecreates/tmp/x/agent.db.pi_logins()reads pi'sauth.jsonthere, butomp_logins()reads~/.omp/agent/agent.dbunconditionally, so a machine that relocated the agent directory has its Antigravity sign-in in omp invisible to the collector: no plan and no limits for an account that is signed in. pi's sign-in in the same directory is found, which makes it look like a working setup.Carried over from #15892, which was written against #14040's branch and auto-closed when that branch was merged and deleted. This is the same change on top of
quattro, keeping the harness test case beside pi's in the shared-fixtures form, including the check that omp's store is never written.Without the collector change the new case fails; with it, all four
agent-usage-agy-*tests pass (21, 39, 6 and 29 ok).The second commit is omarchybot's README line from its verification run against #15892.