Repository navigation
Give the ASUS ProArt P16 (N1x) the ProArt P14's room for USB4 docks - #16667
trukhinyuri wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; the previous empty-file issue is fixed and no new blocking issues were found. SummaryGives the ASUS ProArt P16 the same USB4 bus space and memory windows as the P14.
Reviews (3) · Last reviewed commit: "Give the ASUS ProArt P16 (N1x) the ProAr..." · Reviewed by Greptile |
|
Most of this is in the kernel now, so this PR can shrink to the bus padding.
#16758 took both out of On the P14 with 7.3-3 and no rule, the empty tunnel root ports sit in D3cold and a CalDigit TS4 still comes up with its Ethernet. If you can check the Surface dock on the P16 the same way, that'd be great. |
9af2bd2 to
235ccc1
Compare
|
Shrunk to the bus padding and rebased on quattro. Checked on the P16 with a 7.3 build that carries 1105 and 1112 and no rule: the two empty tunnel root ports ( |
The P16 has the P14's three USB4 host routers (ACPI NVDA8100) and three 10de:22cf tunnel root ports, but n1x.sh matched only the P14's H7407BA, so the P16 got the other N1x laptops' pci=hpbussize=0x20. Match H7607BA too, so it reserves the P14's bus numbers and windows behind those ports. linux-omarchy 7.3-3 keeps the USB4 resources and a tunnel root port awake by itself, so this is only the bus padding. 1793143637 gives existing P16 installs the ProArt drop-in when theirs is one Omarchy wrote, from n1x.sh or 1790984600, and rebuilds once. Like 1791621765 it stays pending when limine-mkinitcpio reports a kernel it could not rebuild; a drop-in the administrator wrote is left alone. Tested on a ProArt P16 H7607BA, BIOS 303, with these sizes: the tunnel root ports get buses 01-80, and a Surface Thunderbolt 4 Dock's PCIe switch comes up behind one of them.
235ccc1 to
de77db5
Compare
|
Reviewed at de77db5 against What was run, on a disposable Omarchy worker (x86, no P16):
Those two drop-in strings are the only ones Omarchy's history has written on a non-P14 N1x, so the migration covers every P16 install. Second opinion: Codex Medium and muse-wonder (via pi, thinking high) reviewed the diff and the same questions. Both found the change proportionate, and found no defect in the drop-in matching, the marker or the failure path; how independent that agreement is can't be guaranteed. Both raised the same point, which I checked against the source:
muse-wonder also noted that the timestamp What it waits on: the bus and window sizes are the actual fix, and they can only be proved on a P16. The author's own test is in the description, but under omabot's rules the author of a hardware fix can't be the one who confirms it. It needs a maintainer to confirm it on a P16 at this head, or to accept the author's test. |
The P16 has the P14's three USB4 host routers (ACPI NVDA8100) and three 10de:22cf tunnel root ports, but
install/hardware/n1x.shmatched only the P14's H7407BA, so the P16 got the other N1x laptops'pci=hpbussize=0x20. This matches H7607BA too, so it reserves the P14's bus numbers and windows behind those ports.linux-omarchy 7.3-3 keeps the USB4 resources and a tunnel root port awake by itself (#1671, 1105 and 1112), so this is only the bus padding. Migration 1793143637 gives existing P16 installs the ProArt drop-in when theirs is one Omarchy wrote, from n1x.sh or 1790984600, and rebuilds once. Like 1791621765 it stays pending when limine-mkinitcpio reports a kernel it could not rebuild; a drop-in the administrator wrote is left alone.
Tested on a ProArt P16 H7607BA, BIOS 303: the tunnel root ports get buses 01-80, the empty ones sit in D3cold, and a Surface Thunderbolt 4 Dock's PCIe switch and 2.5GbE come up behind one of them.