Skip to content

Hide the dock behind the screensaver - #16723

Closed
falkoro wants to merge 1 commit into
omacom:quattrofrom
falkoro:fix/omarchy-dock-over-screensaver-fix
Closed

falkoro wants to merge 1 commit into
omacom:quattrofrom
falkoro:fix/omarchy-dock-over-screensaver-fix

Conversation

@falkoro

@falkoro falkoro commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

On a floating workspace, starting the screensaver left the dock drawn on top of it.

The screensaver opens fullscreen on a special workspace, but the dock's fullscreen check in shell/plugins/dock/DockWindow.qml (lines 27-39) only counted windows on the monitor's regular workspace, so it never saw the screensaver.

The dock now also counts fullscreen windows on the special workspace shown on its monitor. It follows Hyprland's activespecial event for that, since Quickshell does not refresh a monitor's special workspace when it changes. The check moved into DockModel.fullscreenMode, and behaviour on regular workspaces is unchanged.

Verified with new cases in test/shell.d/dock-test.sh (a fullscreen window only on the shown special workspace hides the dock), which fail without this change.

Fixes #16717

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

The dock now hides when a fullscreen window occupies the special workspace shown on its monitor.

  • The dock hides behind fullscreen windows on a shown special workspace.

No actionable issues were found. This review checked the code; it did not run tests or a desktop session.

Reviews (1) · Last reviewed commit: "Hide the dock behind a fullscreen window..." · Reviewed by Greptile

@falkoro falkoro changed the title fix(shell): hide the dock behind a fullscreen screensaver on a special workspace Hide the dock behind the screensaver Oct 26, 2026
@falkoro

falkoro commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Closing: since fdbe182 the screensaver is a native Wayland overlay-layer surface, which Hyprland draws above the dock's top layer, so #16717 can no longer happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dock draws over the screensaver since it moved to a special workspace

1 participant