Repository navigation
Conversation
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryThe dock now hides when a fullscreen window occupies the special workspace shown on its monitor.
No actionable issues were found. This review checked the code; it did not run tests or a desktop session. Reviews (1) · Last reviewed commit: "Hide the dock behind a fullscreen window..." · Reviewed by Greptile |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a floating workspace, starting the screensaver left the dock drawn on top of it.
The screensaver opens fullscreen on a special workspace, but the dock's fullscreen check in
shell/plugins/dock/DockWindow.qml(lines 27-39) only counted windows on the monitor's regular workspace, so it never saw the screensaver.The dock now also counts fullscreen windows on the special workspace shown on its monitor. It follows Hyprland's
activespecialevent for that, since Quickshell does not refresh a monitor's special workspace when it changes. The check moved intoDockModel.fullscreenMode, and behaviour on regular workspaces is unchanged.Verified with new cases in
test/shell.d/dock-test.sh(a fullscreen window only on the shown special workspace hides the dock), which fail without this change.Fixes #16717
🤖 Generated with Claude Code