Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge. Summary
Reviews (2) · Last reviewed commit: "Tell one bracketed argument from two in ..." · Reviewed by Greptile |
Collaborator
|
Reviewed and verified on a worker built from the Omarchy ISO (Quickshell 0.3.2), with this branch linked as the running shell and the shell's socket moved aside so every call took the
Nothing pushed, and nothing is needed from you. It's waiting on the maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
omarchy-shellreaches the shell throughqs ipcrather than its socket, a JSON array argument does not arrive as sent.qs ipc calltakes its arguments as a CLI11 multi-value positional, and CLI11 reads an argument in brackets as a list:'["a"]'is worse: it is accepted and stored as the string"a".The socket path sends arguments verbatim, so this only bites on the fallback: no socket yet, a stale one, a
SKIPanswer, or an argument holding a separator. Releases without the socket (4.0.6 here) hit it on every call.The fallback now prefixes a space to any argument that starts with
[and ends with]. CLI11 leaves that alone, andJSON.parseskips the space. Only fully bracketed arguments change, and those already lose their brackets today, so no argument that works now is altered. The socket path is untouched.Quickshell knows about it (quickshell-mirror/quickshell#22): the maintainer calls it a misfeature of the argument parser that can't be disabled, triggered only when the first character is
[and the last is]. This keeps Omarchy's callers correct meanwhile.Validation
test/shell.d/shell-ipc-test.sh: a JSON array reachesqs ipcas one argument (fails without the fix), and travels over the socket unchanged. The file passes.2b4501a): checkedqs ipc calldirectly.'[]','["a","b"]'and'["a"]'are mangled; with the leading space,' []',' ["a","b"]'and' [["x"],{"y":[1]}]'arrive intact.omarchy-shellsets[],["a","b"]and["x"]throughsetBarWidget, andshell.jsonreads them back as the same arrays. The installed one fails with the errors above.quattroshell, where the socket path normally answers.