Skip to content

Show accessible fingerprint and password lock feedback - #16839

Open
mmdisbrow wants to merge 2 commits into
omacom:quattrofrom
mmdisbrow:ready/omarchy-lock-feedback
Open

mmdisbrow wants to merge 2 commits into
omacom:quattrofrom
mmdisbrow:ready/omarchy-lock-feedback

Conversation

@mmdisbrow

Copy link
Copy Markdown

Make lock authentication feedback legible without relying on color alone. Add distinct fingerprint/password status presentation and translated accessible text while preserving the current upstream password-dot scaling behavior.

The actual lock-indicator QML fixture passes on the prepared branch. This builds on bounded enrollment discovery.

Coordinate with the existing fingerprint feedback proposal #13918 before landing overlapping UI changes.

Related upstream work: #13918.

Local review base and upstream target: quattro at a9cedf93e0356d475411510e818e7e054a924d55 in https://github.com/omacom/omarchy. This branch has been rebased independently onto upstream; the former mechanical stack is excluded. Its affected tests pass on this individual branch.

Validation:

  • Seven focused shell/QML/i18n suites have passing evidence. The corrected detector passes all 37 assertions; unchanged suites retain identical tested contribution inputs. The later upstream bar, plugin-registry and fastfetch changes and exact evidence identities are recorded in the validation report.

Upstream changes since the hardware qualification are preserved and checked offline. The exact rebased composition has not been reinstalled or requalified on hardware.

AI-assisted implementation/preparation with OpenAI Codex. No new contributor DCO certification is asserted.

Independent-branch preparation: contribution changes were preserved while removing unrelated predecessor work. This branch was checked offline; no new hardware qualification is claimed.

(cherry picked from commit 98e389916ffe6e13353a8b83cb8b29b9d00bbf24)
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; readable lock feedback is restored without changing authentication decisions.

Summary

Adds distinct password and fingerprint icons with accessible labels. The latest change restores readable status text alongside those icons.

  • The lock screen shows readable and spoken authentication feedback.

Reviews (2) · Last reviewed commit: "Keep readable lock status alongside auth..." · Reviewed by Greptile

Comment thread shell/plugins/lock/LockView.qml Resolved
Show translated checking, failure and reader-unavailable explanations alongside the icons, including checking a nonempty password. Verify the QML states, existing i18n keys and rendered normal/narrow layouts.

AI-assisted follow-up with OpenAI Codex.
@omarchybot omarchybot added the enhancement New feature or request label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants