Repository navigation
Conversation
(cherry picked from commit 98e389916ffe6e13353a8b83cb8b29b9d00bbf24)
Contributor
[Medium impact] The PR appears safe to merge; readable lock feedback is restored without changing authentication decisions. SummaryAdds distinct password and fingerprint icons with accessible labels. The latest change restores readable status text alongside those icons.
Reviews (2) · Last reviewed commit: "Keep readable lock status alongside auth..." · Reviewed by Greptile |
Show translated checking, failure and reader-unavailable explanations alongside the icons, including checking a nonempty password. Verify the QML states, existing i18n keys and rendered normal/narrow layouts. AI-assisted follow-up with OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make lock authentication feedback legible without relying on color alone. Add distinct fingerprint/password status presentation and translated accessible text while preserving the current upstream password-dot scaling behavior.
The actual lock-indicator QML fixture passes on the prepared branch. This builds on bounded enrollment discovery.
Coordinate with the existing fingerprint feedback proposal #13918 before landing overlapping UI changes.
Related upstream work: #13918.
Local review base and upstream target:
quattroata9cedf93e0356d475411510e818e7e054a924d55inhttps://github.com/omacom/omarchy. This branch has been rebased independently onto upstream; the former mechanical stack is excluded. Its affected tests pass on this individual branch.Validation:
Upstream changes since the hardware qualification are preserved and checked offline. The exact rebased composition has not been reinstalled or requalified on hardware.
AI-assisted implementation/preparation with OpenAI Codex. No new contributor DCO certification is asserted.
Independent-branch preparation: contribution changes were preserved while removing unrelated predecessor work. This branch was checked offline; no new hardware qualification is claimed.