Repository navigation
Conversation
AI-assisted preparation with OpenAI Codex. Validation is recorded in the accompanying review packet; no new DCO sign-off is supplied.
AI-assisted fix with OpenAI Codex following independent review. No contributor DCO certification is asserted.
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryBounds platform fingerprint value reads while keeping USB detection available when platform checks fail.
Review was based on code inspection; tests were not run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform value reads must not block USB fallback on a FIFO, stalled read or malformed stream. Check file type, limit each read to 257 bytes and 250 ms with a 100 ms kill grace, and compare complete tokens without dropping NULs or truncating oversized values into matches.
Behavioral fixtures now cover FIFO, oversized, NUL-containing and stalled value reads, with and without a valid USB fallback, plus the Mac runtime integration contract. These are per-read bounds, not a total platform-scan deadline. This change is useful independently of general M1 enablement.
Coordinate with #15334, which proposes overlapping bounded reader detection, instead of landing competing implementations.
Related upstream work: #15334.
Local review base and upstream target:
quattroata9cedf93e0356d475411510e818e7e054a924d55inhttps://github.com/omacom/omarchy. This branch has been rebased independently onto upstream; the former mechanical stack is excluded. Its affected tests pass on this individual branch.Validation:
Upstream changes since the hardware qualification are preserved and checked offline. The exact rebased composition has not been reinstalled or requalified on hardware.
AI-assisted implementation/preparation with OpenAI Codex. No new contributor DCO certification is asserted.
Independent-branch preparation: contribution changes were preserved while removing unrelated predecessor work. This branch was checked offline; no new hardware qualification is claimed.