Skip to content

Bound platform fingerprint value reads while preserving USB detection - #16842

Open
mmdisbrow wants to merge 2 commits into
omacom:quattrofrom
mmdisbrow:ready/omarchy-reader-detection
Open

mmdisbrow wants to merge 2 commits into
omacom:quattrofrom
mmdisbrow:ready/omarchy-reader-detection

Conversation

@mmdisbrow

Copy link
Copy Markdown

Platform value reads must not block USB fallback on a FIFO, stalled read or malformed stream. Check file type, limit each read to 257 bytes and 250 ms with a 100 ms kill grace, and compare complete tokens without dropping NULs or truncating oversized values into matches.

Behavioral fixtures now cover FIFO, oversized, NUL-containing and stalled value reads, with and without a valid USB fallback, plus the Mac runtime integration contract. These are per-read bounds, not a total platform-scan deadline. This change is useful independently of general M1 enablement.

Coordinate with #15334, which proposes overlapping bounded reader detection, instead of landing competing implementations.

Related upstream work: #15334.

Local review base and upstream target: quattro at a9cedf93e0356d475411510e818e7e054a924d55 in https://github.com/omacom/omarchy. This branch has been rebased independently onto upstream; the former mechanical stack is excluded. Its affected tests pass on this individual branch.

Validation:

  • Seven focused shell/QML/i18n suites have passing evidence. The corrected detector passes all 37 assertions; unchanged suites retain identical tested contribution inputs. The later upstream bar, plugin-registry and fastfetch changes and exact evidence identities are recorded in the validation report.

Upstream changes since the hardware qualification are preserved and checked offline. The exact rebased composition has not been reinstalled or requalified on hardware.

AI-assisted implementation/preparation with OpenAI Codex. No new contributor DCO certification is asserted.

Independent-branch preparation: contribution changes were preserved while removing unrelated predecessor work. This branch was checked offline; no new hardware qualification is claimed.

AI-assisted preparation with OpenAI Codex. Validation is recorded in the accompanying review packet; no new DCO sign-off is supplied.
AI-assisted fix with OpenAI Codex following independent review. No contributor DCO certification is asserted.
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Bounds platform fingerprint value reads while keeping USB detection available when platform checks fail.

  • Platform reader checks no longer stall before USB detection.
  • Platform reader entries can require live value or existence guards.

Review was based on code inspection; tests were not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Platform declaration] --> B{All guards pass?}
  B -->|Yes| C[Read candidate with byte and time limits]
  B -->|No| E[Try next declaration]
  C --> D{Complete token matches?}
  D -->|Yes| F[Reader detected]
  D -->|No| E
  E --> G{More declarations?}
  G -->|Yes| A
  G -->|No| H[Scan USB devices]
Loading

Reviews (1) · Last reviewed commit: "Bound platform fingerprint value reads a..." · Reviewed by Greptile

@omarchybot omarchybot added the enhancement New feature or request label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants