Skip to content

Skip the shell restart when no Hyprland session is running - #17295

Open
c4software wants to merge 1 commit into
omacom:quattrofrom
c4software:skip-shell-restart-headless
Open

c4software wants to merge 1 commit into
omacom:quattrofrom
c4software:skip-shell-restart-headless

Conversation

@c4software

Copy link
Copy Markdown
Contributor

omarchy update on a machine with no graphical session sits silently for 60 seconds at its shell restart step, right after printing "All plugins have been reloaded", then reports that the shell did not become ready. Nothing is reloaded and nothing can start: it looks hung, and Ctrl-C there aborts the update. On quattro this step runs mid-update, so that would also skip hooks, mise, AUR packages and boot verification.

omarchy-restart-shell spawns the shell through hyprctl dispatch. With no compositor that call fails at once, but its status is discarded and the 60-second readiness loop runs anyway.

The update's service phase now only restarts the shell when the user has a Hyprland process, and says why it skipped otherwise. Other marked services still restart. Checking the process rather than hyprctl keeps the restart working over ssh into a machine with a live desktop, where hyprctl has no instance signature until omarchy-restart-shell derives one.

Tested on a headless machine (multi-user.target, no compositor): the service phase finishes immediately instead of after 60 seconds. On a desktop session, Hyprland is still detected and the restart path is unchanged. test/shell.d/update-restart-phases-test.sh gains a headless case, which fails without the fix.

Related: #16599 makes omarchy-restart-shell itself fail fast when Hyprland is unreachable, which would help its direct callers, but the update would still print the reload message first. #16818 rewrites the same lines' messages, so whichever lands second needs a small rebase.

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Skips the shell restart when the current user has no Hyprland process.

  • The update restarts the shell only when a Hyprland process is running.

No actionable issues found. Tests were inspected, not run.

Reviews (1) · Last reviewed commit: "Skip the shell restart when no Hyprland ..." · Reviewed by Greptile

@omarchybot omarchybot added the bug Something isn't working label Nov 18, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Compared the update/restart callers and full diffs with #13945 and #16599. Both older fixes check Hyprland inside omarchy-restart-shell, covering direct callers as well as updates. This PR’s additional headless skip and explanation have been queued for #13945 to fold in with credit to @c4software; #16818 overlaps the same reporting lines.

Opus 5.5 High and muse-wonder via pi, thinking high agreed that this caller-only fix should wait behind the older helper fixes, but disagreed on which older PR to use; their independence is not guaranteed. No worker tests ran because this stopped at the competing-fix comparison. This stays open for the maintainer’s choice alongside #16599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants