Repository navigation
Conversation
Contributor
[Low impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issue was found. SummaryAdds opt-in Docker coverage for real sudo grant validation, revocation, expiry, and account isolation.
Reviews (2) · Last reviewed commit: "test(sudo): handle include syntax and de..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #16223 and its native credential-validation coverage request.
sudo -n -v, command authorization, revocation, nativeNOTAFTER, and isolation from a second account.Dependency and scope
This complementary PR targets
omabot/pr-16111, the head branch of #16223, rather thanquattro. Its diff is only the coverage follow-up: 3 files, 145 additions. It does not duplicate the production fix or close #16223. Maintainers can integrate this commit into #16223; it is not an independent replacement for that PR.Verification
verifypw = anydefault still allowedsudo -n /usr/bin/true, whilesudo -n -vrefused withsudo: a password is required. The unmodified publisher passed validation.__expireaction and requires both validation and command execution to refuse, without clearing credentials between active use and expiry.git diff --check: PASS.a2b282c5b): four-lens native review approved; exact acknowledgement completed forreview-04e17d535718a34c. Three non-blocking advisories concern duplicate opt-in checking, positional dummy identities, and timeout status handling. That approval is not presented as a new native approval of the later test-only correction below.The native launcher disables networking and pulls, mounts the checkout read-only, uses a read-only container root plus bounded tmpfs state, clears the environment, drops all but identity-switching/audit capabilities, and sets CPU, memory, PID, file-size and wall-clock limits. It never mounts host accounts, sudoers files, credential caches, or the Docker socket inside the container.
Review follow-up: includedir compatibility and busy-host expiry
Commit
7f90def19addresses the two P2 comments on the initial head:#includedirand@includedir, including trailing whitespace, while preserving legacy syntax and rejecting the wrong directory. The old recognizer failed the@/whitespace probe; the correction passes. This is parser coverage, not a claim that the local sudo 1.8.31 image exercised a native@includedirpolicy.visudocalls: the old 3-second hook failed at active command authorization, while the corrected hook passed the same native scenario.Final delayed native integration, plain native integration, before/equal/past-deadline wait probes, Bash syntax and diff checks passed. The follow-up changes only the test helper (9 additions, 3 deletions), not production policy or sandbox privileges. No additional independent verifier was required by its risk-gated assessment plan. Native assessment could not determine a tier because of the ambient untracked scratch declaration; no new native approval of this correction is claimed.
Known verification limits — not a green full-suite claim
These limits were explicitly accepted before submission:
nopasswd-sudo-expiry-test.shin the constrained root container failsstatus must inspect policy without authentication. A single run at the pinned Letsudo -vvalidate against the passwordless sudo grant #16223 base reproduced byte-identical output and exit status. The existing mock fixture assumes a non-root account; this is not caused by the new native hook.passwordless-grant-lifecycle-test.shstops because the local image's oldersystemd-tmpfilesdoes not support--inline. That file and the production scripts are unchanged from the base; later package-scriptlet checks were not reached.Risk: security-sensitive test setup, confined to disposable dummy-account sudo policy. No merge is requested or performed automatically.