Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] This PR appears safe to merge. SummaryMoves the output-folder check into the start path so a running recording can stop after its folder disappears.
Reviews (1) · Last reviewed commit: "Stop a screen recording whose output fol..." · Reviewed by Greptile |
|
I read the directory-check change, the surrounding start/stop and status paths, the tests, and #18895's saved-PID coverage. My classification is GPT-6 High in Codex performed this review; no second model completed an item review. No worker tests ran, and no changes or labels were applied. The saved-PID and state-cleanup coverage queued from #18895 remains pending. This PR is waiting on the maintainer to resolve the classification blocker. |
Renaming or deleting the recordings folder during a recording left it impossible to stop: the check that the folder exists ran before anything else, so
--stop-recordingand the toggle showed "Screen recording directory does not exist" and exited without signalling the recorder, which kept running. Alt+Print also falls through to the capture menu when stop fails. The same happens when a lazy unmount or a removed drive takes the folder away.Only a start needs the folder, because a running recorder holds its file open. The check now runs on the start path, after stop has had its chance. Starting without the folder reports the same error as before.
After a rename the recording is intact in the renamed folder, but stop can't find it there, so it skips finalizing and the saved toast. After a delete, the recording is gone with the folder.
#8809 makes the same move as part of its audio prompt. Whichever lands second can drop its copy.
Tested with
test/shell.d/screenrecording-test.sh, including a new case that fails without this change, and in a VM desktop session with realwf-recorder: onquattrothe recorder keeps running after a rename, and with this change it stops and the file plays.gpu-screen-recordercan't run in that VM (software rendering), so its side was checked by inspection: it writes directly to the final filename and has no rename step.🤖 Generated with Claude Code