Skip to content

Stop a screen recording whose output folder is gone - #17318

Open
yamz8 wants to merge 1 commit into
omacom:quattrofrom
yamz8:fix/stop-recording-without-output-dir
Open

yamz8 wants to merge 1 commit into
omacom:quattrofrom
yamz8:fix/stop-recording-without-output-dir

Conversation

@yamz8

@yamz8 yamz8 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Renaming or deleting the recordings folder during a recording left it impossible to stop: the check that the folder exists ran before anything else, so --stop-recording and the toggle showed "Screen recording directory does not exist" and exited without signalling the recorder, which kept running. Alt+Print also falls through to the capture menu when stop fails. The same happens when a lazy unmount or a removed drive takes the folder away.

Only a start needs the folder, because a running recorder holds its file open. The check now runs on the start path, after stop has had its chance. Starting without the folder reports the same error as before.

After a rename the recording is intact in the renamed folder, but stop can't find it there, so it skips finalizing and the saved toast. After a delete, the recording is gone with the folder.

#8809 makes the same move as part of its audio prompt. Whichever lands second can drop its copy.

Tested with test/shell.d/screenrecording-test.sh, including a new case that fails without this change, and in a VM desktop session with real wf-recorder: on quattro the recorder keeps running after a rename, and with this change it stops and the file plays. gpu-screen-recorder can't run in that VM (software rendering), so its side was checked by inspection: it writes directly to the final filename and has no rename step.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Moves the output-folder check into the start path so a running recording can stop after its folder disappears.

  • Screen recording stops work even when the output folder is gone.

Reviews (1) · Last reviewed commit: "Stop a screen recording whose output fol..." · Reviewed by Greptile

@omarchybot

Copy link
Copy Markdown
Collaborator

I read the directory-check change, the surrounding start/stop and status paths, the tests, and #18895's saved-PID coverage. My classification is bug, but the configured second classifier, deepseek-v4p1-flash at low effort, returned no usable class. Classification is therefore unsettled, and the queue workflow stops here until that classification is resolved.

GPT-6 High in Codex performed this review; no second model completed an item review. No worker tests ran, and no changes or labels were applied. The saved-PID and state-cleanup coverage queued from #18895 remains pending. This PR is waiting on the maintainer to resolve the classification blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants