Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryExtends the lid inhibitor to connected external displays, including HDMI and DisplayPort.
Reviews (2) · Last reviewed commit: "Keep the lid inhibitor through DPMS blan..." · Reviewed by Greptile |
|
Thanks for picking this up! This is the fix I proposed in #15207 (point 1 of my comment), and your version goes one step further: since every connected non-internal connector now counts as external, the inhibitor is already held when the dock is plugged in, before the lock's blank. That also makes the ordering concern from my point 2 moot, so no separate change is needed there. It should cover my setup too, since none of its outputs are eDP, LVDS or DSI: DisplayLink Since the fix builds on the analysis and proposal in #15207, would you mind adding me as co-author on the commit? |
…splays - The lock screen blanks displays with DPMS 5 s after it locks. - DPMS off makes an HDMI or DisplayPort connector read disabled, so logind counts the laptop as undocked and suspends a closed lid. - omarchy-system-lid-inhibit now treats every connected connector except eDP, LVDS and DSI as external, so it holds the handle-lid-switch inhibitor for these displays too. Refs omacom#15207. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: nitroCode777 <260935085+nitroCode777@users.noreply.github.com>
0ab7bd2 to
0aeccde
Compare
For sure. I didn't really do anything here 😂 thanks for your fix proposal here! You're added in |
|
Codex (GPT-6; reasoning effort not exposed) read the diff, discussion, linked issue #15207, and the base branch guidance. My classification is Worker verification and a second opinion on the fix have not run. This waits for classification to be settled before verification can proceed. |
What changes
A docked laptop with its lid closed suspends 5 s after every lock (#15207). The lock screen's
idleBlankTimersends DPMS off, and DPMS off makes a DisplayPort or HDMI connector readenabled=disabledin sysfs. logind counts an external display only while its connector reads enabled, so it switches toDocked=falseand the closed lid suspends the machine.omarchy-system-lid-inhibitalready holds logind'shandle-lid-switchinhibitor for displays that logind does not count, but it looked only at USB, Unknown, DVI-A and Composite connectors. Its comments already say that a display blanked by DPMS should keep a closed laptop awake. This change makes it do that for HDMI and DisplayPort too: every connected connector except eDP, LVDS and DSI counts as external.Nothing else changes:
HandleLidSwitchDocked=ignore.It does not cover logout or the greeter, because the inhibitor is bound to the graphical session. #13778 covers that case with a system service. This PR does not replace it.
Verification
bash test/shell.d/lid-inhibit-test.sh: all pass. The old case "HDMI and DisplayPort displays, which logind counts, take no inhibitor" checked the behaviour this PR changes, so I replaced it with "a DisplayPort display takes the inhibitor". That case fails with the script onquattroand passes with this change.bash test/shell.d/lid-close-test.sh: passes.DP-3, lid closed, on AC:Suspending...17:09:20).Docked=falsefrom 10 s on. Nothing suspended in 45 s, and the journal had no suspend entry.USBconnector was already in the old list, so this change does not affect it.Screenshots
No visible change: it changes when a logind inhibitor is held.
Closes #15207
🤖 Generated with Claude Code