Skip to content

Keep executable installer downloads on HTTPS through redirects - #17904

Open
chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:codex/security-installer-https-redirects
Open

chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:codex/security-installer-https-redirects

Conversation

@chessing234

Copy link
Copy Markdown
Contributor

What changes

Herdr, Battle.net, T3 Code's release discovery/feed/AppImage, and the legacy upgrade archive start at HTTPS URLs but follow redirects without restricting the destination protocol. Require HTTPS for both initial transfers and redirects at all six call sites. curl's default redirect policy otherwise permits HTTP and FTP as well as their encrypted forms: curl documentation.

This is transport hardening and does not pin or authenticate a compromised vendor release. Rust and OCaml are handled separately in #17893.

Verification

All 11 existing T3 AppImage install checks pass, including stable/nightly, ARM feeds, checksum failure and interrupted installation. Bash syntax and whitespace checks pass. No new test asserts literal curl flags; these are declarative protocol restrictions. Real vendor installs and Linux CI remain pending.

Screenshots

No visible change: this changes validation, file handling or execution context without changing desktop layout.

@chessing234
chessing234 marked this pull request as ready for review November 7, 2026 02:17
@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds --proto '=https' and --proto-redir '=https' to six downloads across four commands.

  • Herdr and Battle.net installers only follow HTTPS downloads.
  • T3 Code release downloads stay on HTTPS through redirects.
  • The Quattro upgrade keeps its legacy archive download on HTTPS.

Reviews (1) · Last reviewed commit: "Keep executable installer redirects on H..." · Reviewed by Greptile

@chessing234

Copy link
Copy Markdown
Contributor Author

@ErikMelton Could you review this installer hardening? I’d appreciate a check that the HTTPS-only redirect policy covers the executable download paths without breaking the intended release hosts.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read all six changed download calls, their surrounding error handling, and the existing review comments. CI passes at ff6e9a0f9ab2f9fadfdd4748656555724a2e21ac; worker tests and a reproduction have not run.

Reviewed from source by GPT-6 High in Codex. I classified this as a bug fix, but the configured second classifier returned no classification, so the classification remains unsettled and no second code review ran. This waits for the maintainer to resolve the classification before verification can continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants