Repository navigation
Keep executable installer downloads on HTTPS through redirects - #17904
chessing234 wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge. SummaryAdds
Reviews (1) · Last reviewed commit: "Keep executable installer redirects on H..." · Reviewed by Greptile |
|
@ErikMelton Could you review this installer hardening? I’d appreciate a check that the HTTPS-only redirect policy covers the executable download paths without breaking the intended release hosts. |
|
I read all six changed download calls, their surrounding error handling, and the existing review comments. CI passes at Reviewed from source by GPT-6 High in Codex. I classified this as a bug fix, but the configured second classifier returned no classification, so the classification remains unsettled and no second code review ran. This waits for the maintainer to resolve the classification before verification can continue. |
What changes
Herdr, Battle.net, T3 Code's release discovery/feed/AppImage, and the legacy upgrade archive start at HTTPS URLs but follow redirects without restricting the destination protocol. Require HTTPS for both initial transfers and redirects at all six call sites. curl's default redirect policy otherwise permits HTTP and FTP as well as their encrypted forms: curl documentation.
This is transport hardening and does not pin or authenticate a compromised vendor release. Rust and OCaml are handled separately in #17893.
Verification
All 11 existing T3 AppImage install checks pass, including stable/nightly, ARM feeds, checksum failure and interrupted installation. Bash syntax and whitespace checks pass. No new test asserts literal curl flags; these are declarative protocol restrictions. Real vendor installs and Linux CI remain pending.
Screenshots
No visible change: this changes validation, file handling or execution context without changing desktop layout.