Repository navigation
Show a summary before reviewing plugin update code - #17915
Open
marselnenaj wants to merge 2 commits into
Open
marselnenaj wants to merge 2 commits into
marselnenaj wants to merge 2 commits into
Conversation
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are addressed. SummaryPlugin updates now show a short summary before offering Update, Show code changes, or Skip.
Reviews (2) · Last reviewed commit: "Address plugin update review style and H..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
omarchy plugin update <id>currently prints the full Git diff before asking whether to apply it. A pager can hide that confirmation, making the update look stuck.Show the installed/incoming versions, a compact change summary and up to five incoming commit subjects first, then offer Update, Show code changes or Skip. The optional code viewer displays a
q-to-return hint and returns to the choices without approving anything.Pin the reviewed commit for the merge so another fetch cannot replace the approved revision; refuse mutation if the checkout's HEAD changes during review. The explicit
--yesworkflow, fast-forward requirement, manifest validation and rollback remain available.Related: #12332 and the pager-only proposal #13345.
Verification
bash test/shell.d/plugin-add-test.shpasses. Real local repositories cover summary-first output, opt-in code review, returning to the choices, cancellation, changed FETCH_HEAD, refusal of a changed checkout HEAD even when a fast-forward would still work, non-interactive refusal and explicit--yesupdates.d5b32d24because its default output exposes the source body../test/cli, Bash syntax checks andgit diff --checkpass.Screenshots
Both views use synthetic plugin data. Images are hosted as separate review attachments, outside the PR's source diff.
Before: source diff before confirmation
After: summary and explicit choices