Skip to content

Show a summary before reviewing plugin update code - #17915

Open
marselnenaj wants to merge 2 commits into
omacom:quattrofrom
marselnenaj:fix/plugin-update-summary
Open

marselnenaj wants to merge 2 commits into
omacom:quattrofrom
marselnenaj:fix/plugin-update-summary

Conversation

@marselnenaj

@marselnenaj marselnenaj commented Nov 6, 2026 •

Copy link
Copy Markdown

What changes

omarchy plugin update <id> currently prints the full Git diff before asking whether to apply it. A pager can hide that confirmation, making the update look stuck.

Show the installed/incoming versions, a compact change summary and up to five incoming commit subjects first, then offer Update, Show code changes or Skip. The optional code viewer displays a q-to-return hint and returns to the choices without approving anything.

Pin the reviewed commit for the merge so another fetch cannot replace the approved revision; refuse mutation if the checkout's HEAD changes during review. The explicit --yes workflow, fast-forward requirement, manifest validation and rollback remain available.

Related: #12332 and the pager-only proposal #13345.

Verification

  • bash test/shell.d/plugin-add-test.sh passes. Real local repositories cover summary-first output, opt-in code review, returning to the choices, cancellation, changed FETCH_HEAD, refusal of a changed checkout HEAD even when a fast-forward would still work, non-interactive refusal and explicit --yes updates.
  • The changed-HEAD regression also fails when the refusal guard is removed.
  • The new regression fails with the original updater from base d5b32d24 because its default output exposes the source body.
  • ./test/cli, Bash syntax checks and git diff --check pass.
  • Native Ghostty/Gum preview with a disposable local plugin fixture.

Screenshots

Both views use synthetic plugin data. Images are hosted as separate review attachments, outside the PR's source diff.

Before: source diff before confirmation Original plugin updater showing a raw source diff before confirmation

After: summary and explicit choices

Updated plugin updater showing versions, a short summary and Update, Show code changes, Skip choices

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are addressed.

Summary

Plugin updates now show a short summary before offering Update, Show code changes, or Skip.

  • Plugin updates offer a short summary before showing code or applying changes.
  • An approved plugin update stays tied to the revision shown for review.

Reviews (2) · Last reviewed commit: "Address plugin update review style and H..." · Reviewed by Greptile

Comment thread bin/omarchy-plugin-update Resolved
Comment thread test/shell.d/plugin-add-test.sh Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant