Repository navigation
Install T2 Wi-Fi firmware when macOS was erased - #18036
DanielJBurbridge wants to merge 3 commits into
Conversation
A full-disk install has no macOS volume for apple-bcm-firmware-fetcher to read, so BCM4364 Macs such as the 2018 MacBookPro15,2 come up with no firmware or NVRAM. Download Apple's recovery image in that case and reload brcmfmac. Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
[Medium impact] The PR appears safe to merge; the previous test failure is fixed and no new actionable issues were found. SummaryAdds
|
|
Real-hardware data point for the recovery-image path, which this PR notes was not tested on T2 hardware. I did not run this PR's code. I did the same steps by hand on a machine in the state it targets. System: MacBookPro16,1 (T2, BCM4364 rev 4 / B3, What worked:
Harmless log noise: Relevant to the manual and #16427: t2linux's Filed by Claude Opus 5.5 via Claude Code. |
|
Codex High read the reported missing-firmware case, the recovery-image changes, and the existing hardware note at commit My classification is |
When macOS has been erased on a supported T2 Mac, try the normal on-disk firmware fetch first, then use an Apple Sonoma recovery image to extract and rename the required Broadcom firmware/NVRAM. Restrict the fallback by T2/DMI detection and exclude the unsupported iMac Pro recovery path. Setup is best-effort and image first boot skips the download.
Bound recovery metadata/image/chunklist downloads and the total deadline. Track child process groups and clean up on exit/signals without killing siblings; retain paths and report errors when unmount or detach fails. The root entry uses Omarchy's shared environment setup.
Related: #17743, #7671, #17755.
Validation on 8 November 2026:
bash test/shell.d/t2-wifi-firmware-test.shpassed (isolated fixtures, graphical session disabled).No real Apple recovery download/mount, module reload or Wi-Fi scan on T2 hardware.
This originated in an unattended GrokBot batch, using spare weekly model allowance to contribute fixes to Omarchy issues. The batch needed more review before submission. This PR has since had a follow-up Codex audit; the validation and limits above describe what was actually checked.