Skip to content

Restore Voxtype if Cohere activation fails - #18126

Open
chessing234 wants to merge 2 commits into
omacom:voxtype-cohere-vulkanfrom
chessing234:codex/ryan-voxtype-rollback
Open

chessing234 wants to merge 2 commits into
omacom:voxtype-cohere-vulkanfrom
chessing234:codex/ryan-voxtype-rollback

Conversation

@chessing234

Copy link
Copy Markdown
Contributor

What changes

Follow-up to #13098. If Cohere starts but Voxtype cannot restart with the new drop-in, restore both files and restart the previously active services. Report separately when restoring that setup also fails.

Verification

Added a case that fails the Voxtype restart after Cohere starts. It failed on #13098 and passed after the fix. The full Voxtype setup fixture then passed with a temporary home, a local flock substitute, and mocked systemd. A live Vulkan and systemd session was not available.

Screenshots

No visible change: this restores the existing backend configuration after an activation error.

@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect one user's Voxtype engine setup and its systemd services.

The rollback order should be fixed before merging because it can leave Voxtype using a stopped backend.

Findings

  1. P1 Recovery stops the selected backend ▶

Summary

This PR restores both Voxtype files after Cohere activation fails and reports recovery failures separately.

  • Failed Cohere activation restores the previous Voxtype setup.

Reviews (2) · Last reviewed commit: "Keep the inactive Cohere backend stopped..." · Reviewed by Greptile

Comment thread bin/omarchy-voxtype-cohere Resolved
Comment thread test/shell.d/voxtype-setup-test.sh Resolved
Comment on lines +95 to +100
if (( voxtype_was_active )); then
systemctl --user restart voxtype.service || rollback_failed=1
fi
# The restored drop-in can start the backend as a dependency of Voxtype.
if (( ! backend_was_active )); then
systemctl --user stop voxtype-cohere-vulkan.service || rollback_failed=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Recovery stops the selected backend

When the previous Cohere drop-in exists but the backend was stopped, rollback now restarts voxtype.service before stopping the backend. The restored omarchy-voxtype-daemon can see the healthy backend and start Voxtype with --whisper-mode remote. Rollback then stops that backend, leaving Voxtype pointed at a dead endpoint while reporting that the previous setup was restored.

Restore the stopped backend state without letting the restarted daemon select it.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read the rollback change, the service and daemon it interacts with, the existing review comments, and the base branch’s contributor rules at c1794c24605ba23d0fe2a60a69f04447ffbffb18. Codex High classified this as a bug fix, but the second classifier, DeepSeek V4.1 Flash, returned no classification, so classification remains unsettled. No worker tests or full second review ran, and no code or labels changed. This is waiting on the maintainer to resolve classification before verification can continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants