Repository navigation
Restore Voxtype if Cohere activation fails - #18126
chessing234 wants to merge 2 commits into
Conversation
[Medium impact] The changes affect one user's Voxtype engine setup and its systemd services. The rollback order should be fixed before merging because it can leave Voxtype using a stopped backend. Findings
SummaryThis PR restores both Voxtype files after Cohere activation fails and reports recovery failures separately.
Reviews (2) · Last reviewed commit: "Keep the inactive Cohere backend stopped..." · Reviewed by Greptile |
| if (( voxtype_was_active )); then | ||
| systemctl --user restart voxtype.service || rollback_failed=1 | ||
| fi | ||
| # The restored drop-in can start the backend as a dependency of Voxtype. | ||
| if (( ! backend_was_active )); then | ||
| systemctl --user stop voxtype-cohere-vulkan.service || rollback_failed=1 |
There was a problem hiding this comment.
Recovery stops the selected backend
When the previous Cohere drop-in exists but the backend was stopped, rollback now restarts voxtype.service before stopping the backend. The restored omarchy-voxtype-daemon can see the healthy backend and start Voxtype with --whisper-mode remote. Rollback then stops that backend, leaving Voxtype pointed at a dead endpoint while reporting that the previous setup was restored.
Restore the stopped backend state without letting the restarted daemon select it.
|
I read the rollback change, the service and daemon it interacts with, the existing review comments, and the base branch’s contributor rules at |
What changes
Follow-up to #13098. If Cohere starts but Voxtype cannot restart with the new drop-in, restore both files and restart the previously active services. Report separately when restoring that setup also fails.
Verification
Added a case that fails the Voxtype restart after Cohere starts. It failed on #13098 and passed after the fix. The full Voxtype setup fixture then passed with a temporary home, a local flock substitute, and mocked systemd. A live Vulkan and systemd session was not available.
Screenshots
No visible change: this restores the existing backend configuration after an activation error.