Repository navigation
Conversation
[Medium impact] The PR appears safe to merge, with two non-blocking findings from the previous review still outstanding. FindingsSummaryMoves the update transcript from shared
No new findings were identified in the changes since the previous review. Reviews (2) · Last reviewed commit: "Update docs to reflect new XDG transcrip..." · Reviewed by Greptile |
| update_log="${OMARCHY_UPDATE_LOG:-${XDG_STATE_HOME:-$HOME/.local/state}/omarchy/update.log}" | ||
| [[ -f $update_log ]] || update_log="/tmp/omarchy-update.log" |
There was a problem hiding this comment.
If a previous run left an XDG transcript behind, updating after a downgrade can make omarchy-update-analyze-logs read that stale file. The older updater writes to /tmp/omarchy-update.log without setting OMARCHY_UPDATE_LOG, then installs the new analyzer before calling it. This existence check selects the old XDG file and can miss the current run's initramfs warning.
When OMARCHY_UPDATE_LOGGED is set but OMARCHY_UPDATE_LOG is absent, use the legacy transcript.
| } | ||
|
|
||
| if [[ -z ${OMARCHY_UPDATE_LOGGED:-} ]]; then | ||
| update_log="${OMARCHY_UPDATE_LOG:-${XDG_STATE_HOME:-$HOME/.local/state}/omarchy/update.log}" |
There was a problem hiding this comment.
The new transcript path leaves docs/update-process.md pointing readers to /tmp/omarchy-update.log. Its state-file table, update flow, and debugging instructions now identify a missing or stale file instead of the current transcript. Update those references alongside this change, including the OMARCHY_UPDATE_LOG override and legacy fallback.
|
Thanks for this, @Zhann-th. Before anyone verifies it, it has to be classified, and the two models that classified it disagreed. I (Claude Opus 5.5) read it as a bug fix: From reading the diff against
No other open pull request makes this change. Next step: the maintainer decides how to classify it. The conflict is yours to resolve whenever suits you. |
Summary
Move the
omarchy-updatetranscript from the shared, predictable/tmp/omarchy-update.logpath to the user's private XDG state directory (${XDG_STATE_HOME:-~/.local/state}/omarchy/update.log).Context
Using a fixed path in world-writable
/tmpallows unprivileged processes or multi-user file permission collisions to cause errors duringscript -qefc, preventing the update from running. Storing the transcript in the user's state directory eliminates the collision while preserving backwards compatibility inomarchy-update-analyze-logs.