Skip to content

Give the lock screen ten seconds before it blanks - #18525

Open
blankdean wants to merge 1 commit into
omacom:quattrofrom
blankdean:lock-blank-ten-seconds
Open

blankdean wants to merge 1 commit into
omacom:quattrofrom
blankdean:lock-blank-ten-seconds

Conversation

@blankdean

Copy link
Copy Markdown

What changes

The lock screen powers the display off five seconds after the last input (idleBlankTimer.idleMs). On a monitor that takes about that long to finish waking from DPMS, the picture appears and is switched off again immediately. Keeping the mouse moving or typing is what restarts the countdown and holds the panel up.

This raises that delay to ten seconds. A wake still restarts the countdown, and an untouched lock screen still blanks. The longer grace after a suspend (resumeMs, 15 seconds) is unchanged.

Seen on an HP OMEN 27q over HDMI with an NVIDIA RTX 3070, Omarchy 4.5.0-3. One key or mouse move turns the panel on, the panel spends about five seconds resyncing, and DPMS off lands as the lock screen becomes visible.

Related reports: #7399, #7749, #14227. Other open pull requests approach the same blank differently (#17544, #17271, #8561, #8773).

Verification

bash test/shell.d/lock-fingerprint-service-test.sh passed. That fixture finds the blank timer by its interval, which is now 10000.

The running session was not locked to time a wake, so the ten-second window is not measured on hardware here.

Screenshots

No layout change. The lock screen stays lit for 10 seconds after the last input instead of 5.

Five seconds runs out while a slow monitor is still waking from DPMS, so the
password prompt disappears as soon as it appears. Ten seconds leaves time to
see it and start typing.
@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects the lock screen’s idle display behavior.

The code change appears sound, but the repository's required running-UI timing check must be completed before merging.

Findings

  1. P2 Wake timing remains unchecked ▶

Summary

Extends the lock screen's idle blank delay from five to ten seconds.

  • The lock screen waits ten seconds before blanking after idle.

Reviews (1) · Last reviewed commit: "Give the lock screen ten seconds before ..." · Reviewed by Greptile

// Five seconds runs out while a slow panel is still resyncing after DPMS
// off, so the lock blanks again as the picture appears. Ten seconds leaves
// a visible window to start the password.
readonly property int idleMs: 10000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Wake timing remains unchecked

The new ten-second window has not been checked in the running lock screen. AGENTS.md requires running-UI verification for visual changes, and its linked guide requires a short recording for timing changes. The fingerprint fixture checks service behavior, not how long a waking display stays visible.

Exercise the changed countdown, check that input restarts it and an untouched screen blanks, and attach the required timing evidence before merging.

File Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@raffsmagic

Copy link
Copy Markdown

Tested on a Dell XPS 9320 (built-in screen), on top of quattro:

  • Locked and left it: dark about 12s after locking (the 10s plus the lock appearing).
  • Moved the mouse while dark: back on, dark again 10s later.
  • Pressed volume up while dark: back on, dark again about 12s later. That's with my Keep the lock screen dark after a media key wakes it #18595 on top, which reads idleBlankTimer.idleMs, so it follows your 10s without changes.

I couldn't test the slow external monitor case, but 10s doesn't feel too long on a laptop either.

@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Nov 17, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 7dc6ffc2. Claude Opus 5.5 and Codex Medium each classified this separately as a hardware-dependent bug and agreed, so it has the bug and compatibility labels. The diff is correct as far as it goes. Raising idleMs reaches every default arm through armBlankTimer() (Service.qml:252) and the interval: idleMs binding, the post-suspend wall-clock check at :784 scales with it, and the fixture's timer lookup was updated to match. Thanks for keeping it to one constant.

Competing fix. #8561 (opened 2026-08-27) fixes the same re-blank the same way: it raises the idle blank interval for every arm, to 30 seconds instead of 10. When two fixes for one bug are similar, the older one is preferred unless the newer one shows that it misses a case, breaks something, or does not fix the cause. I found none of those in #8561. Its merge conflict comes from predating the idleMs/resumeMs split, and rebasing fixes that. How long the lock stays lit is a policy choice for the maintainer, not a defect in either pull request. Three other open pull requests take different approaches to the same bug: #8773 adds a 30-second grace only after waking a blanked display, #17271 waits for dpmsStatus before starting the countdown, and #17544 adds a 15-second grace on the first wake.

Codex Medium and muse-wonder (via pi, thinking high) were asked to compare all five without being given my answer. Both preferred #8561, and both found no defect in this diff and nothing here that #8561 lacks. They can read this session's notes, so their agreement may not be independent. muse-wonder added a point about margin. The countdown still starts at the wake keypress (runWake(), Service.qml:257), so a panel that takes about 5 seconds to resync leaves about 5 seconds of visible lock, minus the wake's own latency. A panel slower than about 10 seconds would still be blanked before it shows anything. On #7399, the original reporter found that even 30 seconds did not help their panel, while another user found that 20 seconds did.

Not run. Because this one loses to the older fix, I did not run it on a worker or label it verified. @raffsmagic's test above on a Dell XPS 9320 internal display shows the 10-second blank behaving as described. That machine does not have the slow external panel this targets.

Next: this waits on the maintainer to choose among #8561, this pull request and the other approaches above. Nothing is needed from you in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants