Skip to content

Support the 2011 15-inch MacBook Pro hardware - #18571

Open
MarkPronkin wants to merge 1 commit into
omacom:quattrofrom
MarkPronkin:macbookpro-2011-support
Open

MarkPronkin wants to merge 1 commit into
omacom:quattrofrom
MarkPronkin:macbookpro-2011-support

Conversation

@MarkPronkin

@MarkPronkin MarkPronkin commented Nov 11, 2026 •

Copy link
Copy Markdown

What changes

Make the tested 15-inch 2011 MacBook Pro (MacBookPro8,2) work through Omarchy's normal hardware and per-user setup paths.

  • Select the legacy i965 VA-API package for this model instead of relying on its inconsistent Intel marketing name. Extend the existing video-decoding helper for mpv's VA-API/OpenGL defaults while preserving global user options and profile sections. Move its existing user setup leaf out of the Qualcomm directory so it runs once for both families.
  • Install lp8545-backlight-dkms only when the exact model's Intel HD 3000 is present and no AMD display controller is visible. Its registered backlight takes priority over gmux. Deferred first boot explicitly loads it; ordinary installs use its boot-time module entry. GPU firmware, power and mux settings are outside this setup.
  • Add omarchy setup apple-display-profile for a user-supplied Apple display-override archive. It matches the actual internal-panel EDID, derives ICC primaries/TRCs with LittleCMS, preserves the active monitor layout, and rolls back changed files if Hyprland rejects the rule. Dry-run, standalone generation, removal, backups and XDG_DATA_HOME are supported. Apply/removal reject XDG_CONFIG_HOME values outside the module tree loaded by Omarchy. No Apple characterization data is bundled or downloaded.
  • Reuse the existing BCM4331 wl setup. Later local Bluetooth comparisons found recurring audio cuts with the experimental b43 series, so that series is not made the default. Its original author, Shupeng Xue, is credited in the provenance documentation; no third-party driver code is relabeled as this contribution.

Dependency: omacom/omarchy-pkgs#2574 adds the backlight package and extends the existing power-profile daemon's cpufreq backend for this Mac. It retains the existing D-Bus, authorization, holds, persistence and resume machinery. Merge the package PR and publish its packages before merging this integration. Both PRs contain one commit, authored by @MarkPronkin.

The broader Intel-generation detector already has an open proposal in #8514. This PR adds only the scoped MacBook case and does not introduce another general Intel detector.

Verification

  • Focused hardware-quirks, video-decode, backlight-selection and color-profile tests pass. The ten color tests use synthetic EDID/response data, verify the actual ICC curves and D50 transforms, and exercise rollback and idempotency.
  • omarchy commands --check passes with the new command. git diff --check is clean.
  • Read-only checks on the target Mac confirm i965 VA-API profiles and exact 0610:9ca3/LVDS-1 matching; the importer dry-run preserves 1440×900 at the active refresh rate, layout and SDR settings.
  • Companion package validation: the LP8545 module builds with W=1, the package builds with makepkg, and all 62 relevant power-profile integration tests pass over private D-Bus and simulated sysfs.
  • Original full ./test/all run before the focused review fixes: the CLI suite passes; 423 of 424 shell test files completed without failures, with four files reporting skipped checks. The sole failure was the unrelated agent-account-test.sh cancellation case reading login.pid before it existed during the parallel run. That file passes both on unchanged upstream (551dc62) and on this branch in isolation, consistent with a timing race under load. The full suite was run once; its failure is retained in the report rather than presented as a clean aggregate pass.

The revised module/backend have not been activated on the running desktop. A clean install, physical reboot and suspend/resume remain release validation. Existing machines using the separate local power daemon must uninstall that prototype first; its installer masks the stock daemon. Fresh installations use the packaged backend directly.

Review fixes

  • Include lp8545-backlight-dkms in install/omarchy-other.packages, which supplies the offline ISO mirror.
  • Reject a different XDG_CONFIG_HOME for apply, dry-run and removal before writing. Omarchy's Lua bootstrap loads monitor modules from ~/.config. Standalone generation stays independent of that path.
  • Mock the desktop user's UID in the generation test and cover root rejection separately.
  • All 10 color tests pass normally and under fakeroot; the new config-path regression test fails on the previous implementation. The platform-package suite and a live read-only color-import dry-run pass too.

Screenshots

No visible change to shell layout or styling: this is hardware provisioning and an optional color importer. Live validation used the importer's read-only dry-run; it did not replace the running desktop's monitor configuration.

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed code appears safe to merge once the documented companion packages are published.

Summary

Adds scoped support for the 2011 15-inch MacBook Pro:

  • MacBookPro8,2 gets mpv hardware-decoding defaults.
  • MacBookPro8,2 can use the LP8545 panel backlight.
  • Users can apply a matching Apple panel profile in Hyprland.

The companion packages must be published before this integration merges. Physical reboot and suspend/resume checks remain release validation, as documented by the author.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Local Apple archive] --> B[Match internal panel EDID]
  B --> C[Build ICC with LittleCMS]
  C --> D{Requested mode}
  D -->|Generate only| E[Write standalone ICC]
  D -->|Dry run| F[Print proposed changes]
  D -->|Apply| G[Back up and write ICC and monitor rule]
  G --> H[Reload Hyprland]
  H --> I{Configuration clean?}
  I -->|Yes| J[Keep changes]
  I -->|No| K[Restore changed files]
Loading

Reviews (2) · Last reviewed commit: "Support the 2011 15-inch MacBook Pro har..." · Reviewed by Greptile

Comment thread default/color/apple-display-profile.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants