Repository navigation
Support the 2011 15-inch MacBook Pro hardware - #18571
Open
MarkPronkin wants to merge 1 commit into
Open
MarkPronkin wants to merge 1 commit into
MarkPronkin wants to merge 1 commit into
Conversation
MarkPronkin
marked this pull request as ready for review
November 11, 2026 23:54
Contributor
[Medium impact] The reviewed code appears safe to merge once the documented companion packages are published. SummaryAdds scoped support for the 2011 15-inch MacBook Pro:
The companion packages must be published before this integration merges. Physical reboot and suspend/resume checks remain release validation, as documented by the author.
|
MarkPronkin
force-pushed
the
macbookpro-2011-support
branch
from
November 12, 2026 00:04
02a424b to
527acf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Make the tested 15-inch 2011 MacBook Pro (
MacBookPro8,2) work through Omarchy's normal hardware and per-user setup paths.lp8545-backlight-dkmsonly when the exact model's Intel HD 3000 is present and no AMD display controller is visible. Its registered backlight takes priority over gmux. Deferred first boot explicitly loads it; ordinary installs use its boot-time module entry. GPU firmware, power and mux settings are outside this setup.omarchy setup apple-display-profilefor a user-supplied Apple display-override archive. It matches the actual internal-panel EDID, derives ICC primaries/TRCs with LittleCMS, preserves the active monitor layout, and rolls back changed files if Hyprland rejects the rule. Dry-run, standalone generation, removal, backups and XDG_DATA_HOME are supported. Apply/removal reject XDG_CONFIG_HOME values outside the module tree loaded by Omarchy. No Apple characterization data is bundled or downloaded.wlsetup. Later local Bluetooth comparisons found recurring audio cuts with the experimental b43 series, so that series is not made the default. Its original author, Shupeng Xue, is credited in the provenance documentation; no third-party driver code is relabeled as this contribution.Dependency: omacom/omarchy-pkgs#2574 adds the backlight package and extends the existing power-profile daemon's cpufreq backend for this Mac. It retains the existing D-Bus, authorization, holds, persistence and resume machinery. Merge the package PR and publish its packages before merging this integration. Both PRs contain one commit, authored by @MarkPronkin.
The broader Intel-generation detector already has an open proposal in #8514. This PR adds only the scoped MacBook case and does not introduce another general Intel detector.
Verification
omarchy commands --checkpasses with the new command.git diff --checkis clean.0610:9ca3/LVDS-1matching; the importer dry-run preserves 1440×900 at the active refresh rate, layout and SDR settings.W=1, the package builds with makepkg, and all 62 relevant power-profile integration tests pass over private D-Bus and simulated sysfs../test/allrun before the focused review fixes: the CLI suite passes; 423 of 424 shell test files completed without failures, with four files reporting skipped checks. The sole failure was the unrelatedagent-account-test.shcancellation case readinglogin.pidbefore it existed during the parallel run. That file passes both on unchanged upstream (551dc62) and on this branch in isolation, consistent with a timing race under load. The full suite was run once; its failure is retained in the report rather than presented as a clean aggregate pass.The revised module/backend have not been activated on the running desktop. A clean install, physical reboot and suspend/resume remain release validation. Existing machines using the separate local power daemon must uninstall that prototype first; its installer masks the stock daemon. Fresh installations use the packaged backend directly.
Review fixes
lp8545-backlight-dkmsininstall/omarchy-other.packages, which supplies the offline ISO mirror.XDG_CONFIG_HOMEfor apply, dry-run and removal before writing. Omarchy's Lua bootstrap loads monitor modules from~/.config. Standalone generation stays independent of that path.Screenshots
No visible change to shell layout or styling: this is hardware provisioning and an optional color importer. Live validation used the importer's read-only dry-run; it did not replace the running desktop's monitor configuration.