Repository navigation
Conversation
[Medium impact] The changes appear safe to merge; no new blocking issue was found. SummaryPrebuilt images now rebuild their boot image for the machine that boots them, with a one-time repair for machines that booted older images.
No new actionable issues found. The earlier rebuild and interruption findings are addressed. Reviews (7) · Last reviewed commit: "Confirm Limine installed boot images bef..." · Reviewed by Greptile |
|
Reviewed at 479c315. The boot-image fix does what it says. The branch also carries two other changes that need to come out before this can land. What was checked, on a disposable Omarchy worker
What needs the author: split the branch Besides the boot-image work, this branch carries the dock change from #17339 ( What needs the maintainer: what a failed rebuild should do When the rebuild fails, this keeps the service armed, so the rebuild runs again before the login screen on every boot until one succeeds. #14872, which is older and still open, changes the same failure handling in the same files the other way: it finishes with a warning and leaves the repair to owner setup. The two conflict, and choosing between them is the maintainer's call. Second opinion Codex Medium and muse-wonder via pi (thinking high) reviewed the same head. Both independently raised the split and the overlap with #14872 (independence is not guaranteed, since they can read this session). Their other findings, checked against the source:
Nothing was pushed to the branch. It is waiting on the author for the split and on the maintainer for the failure policy. |
A prebuilt image is built away from the machine it runs on, so the boot image it carries describes the machine that built it: mkinitcpio's autodetect ran there, so the initramfs holds that machine's modules and none of the target's. A display on a discrete GPU then has no driver before the session starts, and the session picks the wrong card. The machine's first boot now rebuilds the boot image for the hardware it runs on, next to the rebuild a step's changed configuration already asked for. A machine that booted an image before this rebuild existed still carries the builder's, and a migration rebuilds it. (cherry picked from commit bdbdf68)
limine-mkinitcpio reports a kernel it could not rebuild and still exits 0, so a run that trusted the exit status recorded a boot image that was never built: the machine kept the boot image it had, and the marker told the migration that the machine's boot image was its own, so the repair was skipped. The first boot and the migration now read the rebuild's output as well as its exit status. A rebuild that failed leaves the machine with the boot image it had, and the rebuild owed. (cherry picked from commit a1da1f7)
The rebuild request was written after the image's manifest was retired, so a first boot that stopped between the two lost the request. The next run found no manifest, no changed input and no request, skipped the rebuild and disabled the service, leaving the builder's boot image and its missing drivers in place. Write the request before the manifest is retired, and owe the rebuild to every machine that booted an image until one lands. (cherry picked from commit e3a123c)
The migration called limine-mkinitcpio outright, but the hook that provides it is not in the default package set. On a machine without it the migration failed and stopped the update with an error the user could not act on. Use the same rebuild the first boot makes: Limine's where the machine has it, mkinitcpio's presets where it does not. (cherry picked from commit 73c63f6)
479c315 to
8896a50
Compare
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
|
@greptile review |
limine-entry-tool can report an installation error and still exit successfully, including with limine-mkinitcpio-hook 1.41.0. Use Scott Jones's confirmation predicate from omacom#14872 in both deferred hardware setup and its repair migration, so failed installations, incomplete builds and empty runs cannot write the completion marker. Keep the existing retry behavior; the owner-setup handoff in omacom#14872 remains a separate maintainer decision. Co-Authored-By: Scott Jones <scottajones@gmail.com> Co-Authored-By: Codex High <noreply@openai.com> Co-Authored-By: Opus 5.5 High <noreply@anthropic.com> Co-Authored-By: muse-wonder via pi, thinking high <noreply@openrouter.ai>
|
Reviewed Pushed On disposable Omarchy workers:
Codex High reviewed and tested the change. Opus 5.5 High and muse-wonder via pi (thinking high) identified the completion-check defect and reviewed its correction; their final round found no further actionable code defects. Their agreement is not guaranteed independent of this session. The workers have no AMD/Intel GPU pair, so these checks establish the rebuild path, not the display result in #18080. @bitta-boo, please test the full commit git clone --no-checkout https://github.com/omacom/omarchy.git ~/omarchy-pr-18756
cd ~/omarchy-pr-18756
git fetch origin pull/18756/head
git checkout --detach cbc5f28f1e81fa04a1530d2d8aa8e4ab831fdadf
OMARCHY_PATH="$PWD" PATH="$PWD/bin:$PATH" bash -euo pipefail migrations/1794576032.shAfter a successful rebuild, reboot and report whether |
Fixes #18080.
A prebuilt image is built away from the machine it runs on, so the boot image it carries describes the machine that built it: mkinitcpio's autodetect runs there, so the initramfs holds that machine's modules and none of the target's. On the reported machine that meant
virtio-gpuand neitheramdgpunori915, soamdgpuloaded only in the real root, after SDDM had already started Hyprland. Hyprland then picked the iGPU with no monitor attached as primary and blitted every frame to the AMD card, which failed withEGL_BAD_ALLOCand the page-flip errors in the log.The machine's first boot now rebuilds the boot image for the hardware it runs on, with the same
limine-mkinitcpio(mkinitcpio with autodetect) that fixes it by hand. It happens where the deferred hardware setup already runs, before the login screen, so the display driver is up before the session starts. A step that changed what the boot image is built from, or asked for the rebuild, still gets one rebuild, and the two share it.A machine that booted a prebuilt image before this change still carries the builder's boot image; a migration rebuilds it once.
Tradeoff: the first boot of an image waits for that rebuild before the login screen appears, and mkinitcpio takes about a minute on a real machine. The initramfs that first boot runs from is still the builder's, so the module fix lands in the next boot's initramfs.