Repository navigation
Stop wf-recorder recordings on a still screen without force-killing them - #18817
Closed
ThePrimeagen wants to merge 2 commits into
Closed
ThePrimeagen wants to merge 2 commits into
ThePrimeagen wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
[Low impact] The PR appears safe to merge, with no outstanding findings. SummaryAdds
Reviews (3) · Last reviewed commit: "Drop the test that only checks wf-record..." · Reviewed by Greptile |
The assertion grepped the stub's arguments for the flag the change adds, which restates the implementation: the stub never records frames or stops on a still screen, so it guards nothing beyond the edit itself. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Closing as a duplicate of #18551, which adds the same -D and was timed on a worker (stop goes from 5.6 s with a killed recorder to 0.3 s with the full file). Reviewed by Claude Opus 5.5 with Codex Medium as a second opinion; its independence is not guaranteed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop a wf-recorder screen recording while nothing on screen moves, and
stop_screenrecordinginbin/omarchy-capture-screenrecordingwaits 5 seconds, kills the recorder and shows "Recording process had to be force-killed. Video may be corrupted." instead of saving it. wf-recorder acts on the stop only after its next frame, and aslaunch_wf_recorderstarts it, a frame comes only when the screen changes.Screenshots
Reproduce
sudo pacman -S --needed wf-recorder.omarchy capture screenrecording --fullscreen.ALT + PRINTto stop the recording.More cases
A region recording
A second toggle that cancels a start while it saves
SIGINT sent to wf-recorder by hand
Related