Skip to content

Stop wf-recorder recordings on a still screen without force-killing them - #18817

Closed
ThePrimeagen wants to merge 2 commits into
omacom:quattrofrom
ThePrimeagen:fix/screenrecord-force-kill
Closed

ThePrimeagen wants to merge 2 commits into
omacom:quattrofrom
ThePrimeagen:fix/screenrecord-force-kill

Conversation

@ThePrimeagen

Copy link
Copy Markdown
Contributor

Stop a wf-recorder screen recording while nothing on screen moves, and stop_screenrecording in bin/omarchy-capture-screenrecording waits 5 seconds, kills the recorder and shows "Recording process had to be force-killed. Video may be corrupted." instead of saving it. wf-recorder acts on the stop only after its next frame, and as launch_wf_recorder starts it, a frame comes only when the screen changes.

Screenshots

Before After
before after

Reproduce

  1. On a machine where gpu-screen-recorder cannot start, such as Apple Silicon or a QEMU VM, make sure wf-recorder is installed: sudo pacman -S --needed wf-recorder.
  2. Start a full-screen recording: omarchy capture screenrecording --fullscreen.
  3. Leave the screen untouched for 10 seconds, within one minute on the bar's clock.
  4. Press ALT + PRINT to stop the recording.
  5. Nothing happens for 5 seconds, then "Screen recording error: Recording process had to be force-killed. Video may be corrupted." appears instead of "Screen recording saved".

More cases

A region recording

Before After
before after

A second toggle that cancels a start while it saves

Before After
before after

SIGINT sent to wf-recorder by hand

Before After
before after

Related

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with no outstanding findings.

Summary

Adds -D to wf-recorder so a still screen keeps supplying frames, allowing the recorder to respond to stop signals.

  • Still-screen recordings can stop without waiting for a screen change.

Reviews (3) · Last reviewed commit: "Drop the test that only checks wf-record..." · Reviewed by Greptile

Comment thread test/shell.d/screenrecording-test.sh Resolved
The assertion grepped the stub's arguments for the flag the change
adds, which restates the implementation: the stub never records frames
or stops on a still screen, so it guards nothing beyond the edit itself.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omarchybot

Copy link
Copy Markdown
Collaborator

Closing as a duplicate of #18551, which adds the same -D and was timed on a worker (stop goes from 5.6 s with a killed recorder to 0.3 s with the full file).

Reviewed by Claude Opus 5.5 with Codex Medium as a second opinion; its independence is not guaranteed.

@omarchybot omarchybot added the duplicate This issue or pull request already exists label Nov 16, 2026
@omarchybot omarchybot closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants