Repository navigation
Conversation
…ive them wtype types through a keymap XWayland clients never load, so its Shift+Insert reaches them as Shift+Escape and nothing is pasted. The clipboard history paste, file paste and emoji picker now send the chord through Hyprland's send_key_state, as the universal clipboard bindings do.
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRoutes clipboard and emoji paste shortcuts through Hyprland instead of
No actionable issues were found. This review checked source code; it did not run tests or a live desktop. Reviews (1) · Last reviewed commit: "Send clipboard paste shortcuts through H..." · Reviewed by Greptile |
|
Reproduced at
A direct helper call in a native GTK window can still fail after GPT-6 High in Codex reviewed the source, callers and worker results. Opus 5.5 High and muse-wonder via pi, thinking high, reviewed the same head and evidence and found no source change needed. Their agreement is not guaranteed independent. This waits on the maintainer to reconcile the shared paste calls with #15343, which already carries |
|
Tested the emoji picker on Omarchy 4.5.0-3, Hyprland 0.56.2, and Firefox 158.0.1 running natively on Wayland. Search + Enter inserted the emoji 0/3 times with the stock helper, 3/3 with the Hyprland key-down/key-up change from this PR, and 3/3 with the Firefox reported |
|
The Firefox comparison confirms that both changes fix that native Wayland emoji case. It does not compare XWayland delivery. The earlier worker run tested this head against the stock helpers, not the GPT-6 in Codex (reasoning effort not exposed), Opus 5.5 High and muse-wonder via pi, thinking high, reviewed the new report and the unchanged head This still waits on the maintainer to reconcile the overlapping fixes. There is nothing further for the author to change from this review. |
|
I ran the XWayland comparison locally on Omarchy 4.5.0-3 and Hyprland 0.56.2. I invoked the paste helpers directly against Firefox 158.0.1 and a GTK3 entry. Across Firefox emoji paste and GTK3 emoji, plain-text, and Both |
|
The new XWayland comparison addresses the gap in the previous review: augustl reports 0/3 with both stock and The source explains the difference: adding VoidSymbol gives wtype another keycode, but leaves Insert at the keycode XWayland reads as Escape. Sending through Hyprland uses the seat's keymap instead. This distinguishes the XWayland case from the native Wayland case where both approaches have been reported to work. GPT-6 in Codex (reasoning effort not exposed), Opus 5.5 High and muse-wonder via pi, thinking high, reviewed the new report against unchanged head This still waits on the maintainer to reconcile #15343 and #15327 on the shared paste calls. There is nothing further for the author to change from this review. |


Part of #16536. Split out of #16537 so the plain fix can be reviewed apart from the Voxtype default change.
Clipboard history paste, file paste and the emoji picker send Shift+Insert through wtype. XWayland apps never load the keymap wtype uploads, so they read the chord as Shift+Escape and nothing is pasted. The issue has the reproduction and a delivery matrix, and a second report covers Foot, T3Code and Zen Browser on 4.5.0-3.
Hyprland can press the keys itself on the seat's own keymap, which XWayland apps receive as sent. Omarchy's universal copy and paste bindings already do this in
default/hypr/bindings/clipboard.lua.What changes
omarchy-hyprland-send-shortcut <mods> <key>(hidden) sends a chord to the focused surface throughhl.dsp.send_key_state, with the same no-window-target and down/up split asclipboard.lua.omarchy-clipboard-paste-text --shift-insert,omarchy-clipboard-paste-fileandomarchy-menu-emoji-insertsend their Shift+Insert through it instead ofwtype -M shift -k Insert -m shift.No defaults or user config change. The
--universalpath added in #17827 is untouched.Testing
bash test/shell.d/clipboard-test.sh,emojis-test.shand./test/cli--ozone-platform=x11and--ozone-platform=wayland, and a GTK key logger under both GDK backends: Hyprland's Shift+Insert pasted intact in both, where wtype's Shift+Insert pasted nothing under XWayland.