Skip to content

Wait for the update lock to come free in the hangup test - #18980

Merged
dhh merged 1 commit into
quattrofrom
fix-update-hangup-lock-race
Nov 15, 2026
Merged

dhh merged 1 commit into
quattrofrom
fix-update-hangup-lock-race

Conversation

@dhh

@dhh dhh commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

What changes

test/shell.d/update-hangup-test.sh (from #16045) checks the update lock with one non-blocking flock right after gum dies, and only afterwards waits for the update launcher to exit. The launcher can still hold the lock on its way out, so the check fails with:

BlockingIOError: [Errno 11] Resource temporarily unavailable

That fails the test check on quattro (runs at 2026-11-14 23:23 and 2026-11-15 09:11) and on every open PR. The test now waits for the lock with its existing until helper, up to the same 10s deadline it gives gum and the launcher. A lock that is never released still fails, with "the update lock was never released".

Verification

  • On quattro locally: the file fails every run with the BlockingIOError above.
  • With this change: three consecutive runs pass, both modes (close-terminal, kill-script).

Screenshots

No visible change: test-only.

🤖 Generated with Claude Code

The test checked the update lock once, right after gum died, while the
update launcher holding it could still be on its way out, so it failed most
runs on quattro and in CI with BlockingIOError. It now waits for the lock the
way it already waits for gum and the launcher, up to its 10s deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Updates test/shell.d/update-hangup-test.sh to wait for the update lock after the terminal closes.

  • The hangup test waits for the update lock to clear.

Reviews (1) · Last reviewed commit: "Wait for the update lock to come free in..." · Reviewed by Greptile

@dhh
dhh merged commit ab1e100 into quattro Nov 15, 2026
2 checks passed
@dhh
dhh deleted the fix-update-hangup-lock-race branch November 15, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant