Repository navigation
Wait for the update lock to come free in the hangup test - #18980
Merged
Merged
Conversation
The test checked the update lock once, right after gum died, while the update launcher holding it could still be on its way out, so it failed most runs on quattro and in CI with BlockingIOError. It now waits for the lock the way it already waits for gum and the launcher, up to its 10s deadline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
[Low impact] This change appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "Wait for the update lock to come free in..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
test/shell.d/update-hangup-test.sh(from #16045) checks the update lock with one non-blockingflockright aftergumdies, and only afterwards waits for the update launcher to exit. The launcher can still hold the lock on its way out, so the check fails with:That fails the
testcheck on quattro (runs at 2026-11-14 23:23 and 2026-11-15 09:11) and on every open PR. The test now waits for the lock with its existinguntilhelper, up to the same 10s deadline it gives gum and the launcher. A lock that is never released still fails, with "the update lock was never released".Verification
BlockingIOErrorabove.close-terminal,kill-script).Screenshots
No visible change: test-only.
🤖 Generated with Claude Code