Repository navigation
Show the cursor again when the screensaver dies without its exit (4.5) - #19117
abhirupghosh wants to merge 2 commits into
Conversation
The screensaver hides the cursor and only shows it again from its own exit path, so a terminal that dies without running it leaves the desktop with no cursor. The idle service now tracks every screensaver window and shows the cursor once the last one closes. Both paths leave the cursor alone while the startup reveal is still pending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nsaver `pgrep -f '[o]rg.omarchy.screensaver'` matched any command line mentioning the class, so an unrelated process could make the launcher think a screensaver was already running, and the exit and lock paths could kill it. Match the terminal launched with the screensaver class instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The changes affect the desktop idle, screensaver, and lock workflow. Fix cursor recovery for screensaver windows that survive a shell restart before merging. Findings
SummaryAdds cursor recovery when the last tracked screensaver window closes.
abhirupghosh explicitly describes preserving startup ownership while
|
| } else if (name === "closewindow") { | ||
| var close = eventParts(event, 1) | ||
| var address = String(close[0] || "") | ||
| if (root.cursorHidingWindows[address]) root.trackCursorHidingWindow(address, false) |
There was a problem hiding this comment.
Restart leaves screensavers untracked
After a shell restart or crash recovery, cursorHidingWindows starts empty even if screensaver windows are still open. This check then ignores those windows when they close. If their terminal dies without running exit_screensaver, the cursor stays hidden. Seed the map from existing screensaver windows when the service starts, alongside watching new events.
|
I reproduced the abrupt-death case on a disposable Omarchy worker using foot: killing the screensaver script and its terminal left Greptile's restart limitation also reproduces: launch the screensaver, run Codex High reviewed and ran the worker checks; Opus 5.5 High and muse-wonder via pi, thinking high reviewed the code. Both reviewers agree that release scope needs a maintainer decision; independence is not guaranteed. The terminal implementation was replaced on These worker captures show the compositor's reported cursor state after all screensaver windows closed; they do not photograph the pointer itself. |


On 4.5 the terminal screensaver hides the cursor and only shows it again from its own exit path. A screensaver terminal that dies without running that path leaves the desktop with no cursor (
cursor:invisiblestaystrue) until it is reset by hand. Quattro's native screensaver handles this inomarchy-system-lock, but 4.5 still ships the terminal one.omarchy_startup_cursor_pending).pgrep -f '[o]rg.omarchy.screensaver'matched any command line mentioning the class. Any process with the class in its arguments made the launcher think a screensaver was already running (it exited silently), and the exit and lock paths could kill that process. The launcher, the screensaver exit,omarchy-system-lockandomarchy-debug-idlenow match only the alacritty/ghostty/foot/kitty process started with--class=/--app-id=org.omarchy.screensaver.Tested on a live 4.5 session (foot): SIGKILLing the screensaver script and its terminal, so its exit never runs, now brings the cursor back, and the shell logs
cursor-show: last screensaver window closed. With a startup reveal pending, the cursor stays hidden. A shell command containing the match pattern is no longer matched../test/allpasses.🤖 Generated with Claude Code