Repository navigation
Conversation
Terminals paste only text, so picking an image from clipboard history while a terminal is focused pasted nothing. Paste the image's file path instead, which image-aware terminal apps like OpenCode attach as an image. Co-authored-by: HIMANSHU11827 <HIMANSHU11827@users.noreply.github.com>
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryImage picks from clipboard history now paste the saved file path into tagged terminals.
Reviews (1) · Last reviewed commit: "Paste an image's path into terminals fro..." · Reviewed by Greptile |
|
GPT-6 in Codex read the diff, the clipboard helper and its caller, the base branch's rules, and #10526, and classified this as a bug fix for image selections that paste nothing into terminals. The separate classifier, deepseek-v4p1-flash, returned No worker tests or full code review were run, and no class or verification labels were added. Waiting on the maintainer to resolve the classification before verification continues. |
What changes
Picking an image from the clipboard history (
Super + Ctrl + V) while a terminal is focused pastes nothing (#10526).omarchy-clipboard-paste-fileputs theimage/pngon the clipboard and sends Shift+Insert, and a terminal's paste only takes text.When the focused window has Omarchy's
terminaltag, this puts the image's file path on the clipboard instead and pastes it with the same Shift+Insert. OpenCode attaches an image whose path is pasted, the same way it does when you copy a PNG in the file manager and paste it into the terminal. Outside terminals, and for Shift+Return (copy only), nothing changes.It builds on #11998 by @HIMANSHU11827, with two differences:
wtype. OpenCode leaves a typed path as plain text and only attaches a pasted one.terminaltag fromdefault/hypr/apps/terminals.lua, the same definitiondefault/hypr/bindings/clipboard.luauses, instead of matching class names.Trade-off: after the paste, the clipboard and the history hold the path rather than the image. Compared with sending Ctrl+V (#10536), a pasted path is harmless at a plain shell prompt or in vim, where Ctrl+V starts quoted-insert or block selection.
Verification
bash test/shell.d/clipboard-test.sh: all 70 checks pass. The new check fails onquattrowithout the fix.hyprctl activewindow -joutput: Ghostty (terminal*) matches, Brave (chromium-based-browser*) doesn't.Screenshots
No visible change: the history panel looks the same; only what gets pasted into a terminal changes.