Skip to content

Stop AUR installs from waiting on file indexing - #19212

Open
americos wants to merge 1 commit into
omacom:quattrofrom
americos:fix-14887-updatedb-nonblocking
Open

americos wants to merge 1 commit into
omacom:quattrofrom
americos:fix-14887-updatedb-nonblocking

Conversation

@americos

Copy link
Copy Markdown

After yay finishes, the AUR picker (omarchy-pkg-aur-install) runs a full sudo updatedb in the foreground. It prints nothing, and with a FUSE or network mount under home (such as an rclone mount) it can take many minutes, so the install looks stuck on the last pacman hook.

This removes that call. The scheduled plocate-updatedb timer, with Omarchy's drop-in options, already indexes the whole system, so newly installed files show up in locate after its next run. Before, an AUR install refreshed the index right away, even on battery. Now that waits for the timer's next run, which needs AC power. The docs paragraph and test/shell.d/locate-test.sh now describe the new behavior.

Part of #14887. #14914 also dropped this call, but it was closed in favor of #16568, which changed sudo handling and kept the call. #15178 fixes the slow crawl itself, for the timer as well, by skipping more mount types. It edits the same line, so the two PRs conflict textually, and whichever lands second resolves it.

Tests: test/shell.d/locate-test.sh passes, and its new check fails without this change. test/cli gives the same result as on unmodified quattro: one failure, "theme template mix helper works", unrelated to this change.

AI assistance was used to prepare this change.

The AUR picker ran a full updatedb in the foreground after yay finished.
With a FUSE or network mount under home that scan can take minutes and
prints nothing, so the install looks hung. Leave indexing to the scheduled
plocate-updatedb service instead. Part of omacom#14887.
@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Removes the foreground file scan after AUR package installation.

  • AUR installs finish without waiting for a locate scan.

americos explicitly acknowledged that deferred indexing, including on battery, is intentional. Newly installed files wait for the next eligible timer run.

Reviews (1) · Last reviewed commit: "Stop AUR installs from waiting on file i..." · Reviewed by Greptile

@omarchybot omarchybot added the bug Something isn't working label Nov 17, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Read the picker, its locate test, the indexing configuration and documentation, #14887, and the related pull requests at 9f8b5cc. No blocking implementation defect was found by reading.

The earlier #15178 addresses the reported remote-mount crawl in both the AUR refresh and the scheduled indexer. This PR removes the AUR refresh but leaves the scheduled crawl unchanged. It also means newly installed files wait for the next eligible timer run, including the existing AC-power condition. That is a separate behavior choice, so there is nothing to fold into #15178 automatically.

GPT-6 via Codex (driver effort not exposed), Opus 5.5 High, and muse-wonder via pi (thinking high) reviewed this comparison. The reviewers agreed that #15178 should proceed for the reported crawl and that this change needs the maintainer's decision; their independence is not guaranteed. No tests ran in this session: the competing-fix comparison stops this PR before worker verification. No commits were pushed. This is waiting on the maintainer to decide whether to remove immediate AUR indexing alongside #15178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants