Repository navigation
List subgroup commands when --help is requested and make the unknown-command suggestion runnable - #19450
List subgroup commands when --help is requested and make the unknown-command suggestion runnable#19450ThePrimeagen wants to merge 2 commits into
Conversation
In dispatch_or_help, strip trailing --help, -h or ? tokens before calling show_prefix_help, so 'omarchy install service --help', 'omarchy install gaming --help' and the printed 'omarchy install ?' match the 'omarchy install service ', 'omarchy install gaming ' and 'omarchy install ' usage prefixes and list those commands instead of falling through to Unknown. Also drop the trailing ' ?' punctuation from the 'Did you mean' line so the suggestion is a runnable command: 'omarchy install bogus' now suggests 'omarchy install', which shows the Install group help, instead of looping on 'omarchy install ?'.
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe CLI now lists subgroup commands when help is requested and prints suggestions that safely open help.
Both previous findings are addressed. Targeted checks passed for subgroup help, unknown-command exit codes, and the migration help suggestion. Bash syntax checks also passed. Reviews (2) · Last reviewed commit: "Suggest --help for unknown commands and ..." · Reviewed by Greptile |
|
Source review by GPT-6 in Codex (high effort) supports Greptile’s migration finding: I classified this as a bug, but the classification check received no valid class from |
|
Source review by GPT-6 in Codex (high effort) of I classified this as a bug, but the configured classifier, |
|
The prefix help bug here is real: on What this one does beyond that fix: It changes the "Did you mean" line to end in This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. |
Typing
omarchy install service --helpin a terminal should list the service installers, butbin/omarchyrefuses it as an unknown command and suggestsomarchy install ?, which fails the same way when run as printed.Screenshots
Reproduce
omarchy install service --helpand press Enter.Unknown Omarchy command: omarchy install service --helpandDid you mean: omarchy install ?with exit 127, instead of listing theomarchy install servicecommands.More cases
Suggestion run verbatim loops
Another subgroup --help
Unknown subcommand under a valid group
Related
--helpcommand for unknown commands instead of the loopingomarchy <group> ?suggestion