Repository navigation
Preserve parsed agent flags in the prompt suggestion and prompt route - #19452
ThePrimeagen wants to merge 3 commits into
Conversation
omarchy-agent now builds its "To pass a prompt" suggestion from the flags it already consumed (--inline, --pick, --local/--local-model, --prefer-local, and --agent) instead of dropping them, so running the suggested command launches the requested agent and mode rather than the default. omarchy-agent-prompt now parses and forwards those same flags to omarchy-agent in any order before the prompt text, instead of treating them as literal prompt text.
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe PR keeps parsed agent options in prompt suggestions and forwards those options through the prompt route.
Reviews (3) · Last reviewed commit: "Stop option parsing on -- in omarchy-age..." · Reviewed by Greptile |
|
I read the diff, surrounding agent launcher code, existing agent tests, and the review comments at 8dcf2cf. Codex (GPT-6; reasoning effort not exposed) classified this as a bug fix, but the second classifier, deepseek-v4p1-flash, returned no valid classification. Classification remains unsettled, so verification has stopped pending another classification pass. No tests ran, and no code or labels changed; no second code review was requested. |
…g on the prompt route
|
I read the updated diff, agent launcher and prompt routing code, regression tests, and review threads at e3c0005. Codex (GPT-6; reasoning effort not exposed) classified this as a bug fix, but the second classifier, deepseek-v4p1-flash, returned no valid classification. Classification remains unsettled, so worker verification has not started. No tests ran, no code or labels changed, and no second code review was requested. This is waiting on a successful classification pass. |
|
Reviewed at e3c0005 by Claude Fable 5.2, with a second opinion from Opus 5.5 (High) and muse-wonder (via pi, thinking high). Classified The bug is real and this fixes it. On a worker running quattro (b20d787), Checked outside the diff: nothing in Two things noted, neither changed here. The suggestion is printed as The second opinion found no defect and judged the size right; it agreed with the reproduction above rather than repeating it, and its independence is not guaranteed. Both of its models raised the two notes above, and both pointed out that the flag list now lives in |
Running
omarchy agent --agent amp hello ampinbin/omarchy-agentprintsTo pass a prompt: omarchy agent prompt "hello amp"with--agent ampdropped. Running that suggestion verbatim therefore launches the default agent, or with no default only asks you to choose one, instead of launching amp with the prompt.Screenshots
Reproduce
omarchy agent --agent amp hello ampand press Enter.To pass a prompt:line — it has no--agent amp.omarchy agent prompt "hello amp", and press Enter.Choose default agent with: omarchy default agent <name>and nothing launches.More cases
Different default set
--inlinedroppedomarchy agent prompthas no--agentpassthroughRelated
omarchy agent promptsuggestion and the prompt splitomarchy-agent-promptroute for empty prompts