Repository navigation
Show nested subcommand help and a runnable suggestion for unknown commands - #19456
ThePrimeagen wants to merge 2 commits into
Conversation
Strip trailing --help/-h before calling show_prefix_help in
dispatch_or_help, so 'omarchy hyprland window --help' (and workspace
layout/monitor equivalents) matches COMMAND_USAGE as
'omarchy hyprland window' and lists its subcommands instead of
falling through to Unknown. Make suggest_command return the full
candidate route instead of only its first word, and print the
suggestion without a separate ' ?' argument ('omarchy <route>?'),
so the suggested command is a runnable full route and does not
re-enter the Unknown/suggest loop as 'omarchy hyprland ?'.
[Low impact] This PR appears safe to merge; no new actionable issues were found. SummaryThis PR fixes help for nested command groups and makes unknown-command suggestions runnable.
Both previous findings are addressed. Bash syntax checks and focused help checks passed; the full CLI suite was not run. Reviews (2) · Last reviewed commit: "Print runnable --help suggestion for unk..." · Reviewed by Greptile |
|
I read the diff, surrounding router code, existing comments, and the base branch’s command guidance. GPT-6 in Codex (effort not exposed by this session) assessed this as a bug fix, but the configured DeepSeek V4.1 Flash classifier returned no classification, so classification remains unsettled. The reviewer health check answered successfully. Worker tests and fixes have not run because the queue workflow stops at an unsettled classification. No labels or commits were added; this is waiting for classification to be resolved. |
|
I read the updated router and regression tests at Worker reproduction and the CLI suite have not run because the queue workflow stops at an unsettled classification. No labels or commits were added. This is waiting for classification to be resolved before verification can proceed. |
|
The prefix help bug here is real: on The prefix fix here is close to #19488's: it strips trailing This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. Classification is unsettled: the two classifying models disagreed on whether this is a bug fix or an enhancement, so it carries no class label. |
Running
omarchy hyprland window --helpinbin/omarchyprintsUnknown Omarchy commandwith no window help, and itsDid you mean: omarchy hyprland ?suggestion loops to itself when run.Screenshots
Reproduce
omarchy hyprland windowand press Enter. It lists the hyprland window commands.omarchy hyprland window --helpand press Enter.Unknown Omarchy command: omarchy hyprland window --helpandDid you mean: omarchy hyprland ?, with no window commands listed.More cases
Running the printed suggestion verbatim loops to itself
Other nested prefix --help
Unknown multi-word command under a valid group
Related
--helpcommand for unknown commands and was about the same un-runnable?suggestion