Repository navigation
List subcommands when --help follows an intermediate command prefix - #19473
ThePrimeagen wants to merge 2 commits into
Conversation
Make the printed `omarchy <group> ?` suggestion work by recognising a bare `?` as a help request alongside --help/-h in remaining_has_help_flag, the $2 group-help checks in both dispatch functions, and main. Strip --help/-h/? from the prefix before show_prefix_help matches it against COMMAND_USAGE, so intermediate prefixes such as `omarchy theme bg --help` and `omarchy install gaming --help` list their subcommands instead of falling through to Unknown, and the `?` suggestion no longer loops on itself.
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe CLI now lists subcommands when help follows an intermediate command prefix and accepts
Reviews (2) · Last reviewed commit: "Avoid glob expansion in prefix help and ..." · Reviewed by Greptile |
|
I read the dispatcher diff, the existing review comments and the base branch’s contributor rules. I classify this as a bug fix, but the configured classification reviewer, deepseek-v4p1-flash, returned no class, so classification remains unsettled. No worker tests ran and no labels or code changed. This needs a completed second classification before verification can continue. Reviewed by GPT-6 High in Codex; no second code review ran. |
|
I read the dispatcher and test changes at Reviewed by GPT-6 in Codex (reasoning effort not exposed to this session); this was the only code review in this run, and no second code review ran. |
|
The prefix help bug here is real: on What this one does beyond that fix: it makes a literal This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. Classification is unsettled: the two classifying models disagreed on whether this is a bug fix or an enhancement, so it carries no class label. |
In
bin/omarchy, runningomarchy theme bg --helpprintsUnknown Omarchy commandand aDid you mean: omarchy theme ?suggestion instead of listing the theme bg subcommands, and that printedomarchy theme ?suggestion is itself refused with the same suggestion again.Screenshots
Reproduce
omarchy theme bg --helpand press Enter.Unknown Omarchy command: omarchy theme bg --helpandDid you mean: omarchy theme ?instead of the theme bg commands.More cases
Printed
?suggestion loops on itselfAnother intermediate prefix is refused
Related
omarchy theme ?suggestion, later narrowed to suggesting--helpinstead and reverting treating?as help