Repository navigation
Show Failed instead of Done when an install fails - #19486
ThePrimeagen wants to merge 1 commit into
Conversation
The presentation wrapper reports Done/Failed from the install script's exit code, but these scripts let a failed omarchy-pkg-add/aur-add fall through to config and launch steps whose success masked the failure. Add || exit 1 after the package install (and exit 1 in the terminal script's failure branch) so the wrapper shows Failed and nothing is launched for a package that was never installed.
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe six installers now return a failure when package installation fails, so the install window shows “Failed” instead of “Done.”
No actionable issues found. Reviews (1) · Last reviewed commit: "Propagate package-install failures in in..." · Reviewed by Greptile |
|
Codex at high effort read the diff, description, comments, surrounding installers, menu callers and base-branch rules. My classification is The diff overlaps #17899 in the terminal and editor installers and #9124 in Dropbox; no choice between these fixes has been made. This stops at classification pending maintainer attention. No tests ran, no code was pushed and no labels were added. |
|
Reviewed at Every file here is already covered by an older open pull request. #17899 (6 November) makes the identical Where the approach differs, the older one covers more. So #17899 is the one that carries the editor and terminal fix, and this pull request is left with the maintainer. Which of #9124 and #17900 carries Dropbox is theirs to choose as well. For ordering: this branch and #17899 each merge cleanly with #18566, which rewrites the launch line at the end of the Emacs, VS Code and Zed installers, but not with each other. #19468 also edits Reviewed by Claude Fable 5.2. Opus 5.5 High and muse-wonder (via pi, thinking high) were given the four diffs and asked which should win without being told my answer: both chose #17899 for the editors and terminal, Opus chose #9124 for Dropbox and muse-wonder #17900, because #9124's bare |
When a package install fails at the sudo prompt, the install window still shows green 'Done!' instead of red 'Failed (exit code 1)!', so a failed install looks successful. This happens in
bin/omarchy-install-editor-emacs, where the script carries on and launchesemacsclientafter the package installer has already failed.Screenshots
Reproduce
Super+Space, typeInstall, pressEnter, typeEditor, pressEnter, typeEmacs, and pressEnter.[sudo] password for prime:prompt in the install window.Ctrl+Cso the package install fails.More cases
VSCode
Terminal (Alacritty)
Dropbox
Also affected
bin/omarchy-install-editor-zed: a failedomarchy-pkg-addis followed by theme setup and a background launch, so the window shows 'Done!'; fixed by this change too.bin/omarchy-install-editor-helix: a failedomarchy-pkg-addis followed by config and an alias check that returns 0, so the window shows 'Done!'; fixed by this change too.Related
omarchy-pkg-addfailure in the Dropbox service installer, fixed here with|| exit 1instead ofset -e.