Repository navigation
Show prefix help for multi-word commands given --help or ? - #19487
ThePrimeagen wants to merge 2 commits into
Conversation
…help lookup '?' was not recognised as help, so 'omarchy audio ?' fell through to Unknown and the suggestion printed the same unrunnable form. Recognising '?' in remaining_has_help_flag and in the group-help shortcuts (both dispatch paths and main) makes it show the listing. dispatch_or_help also passed the full argv including --help to show_prefix_help, so multi-word prefixes such as 'omarchy audio input --help', 'omarchy audio output --help' and 'omarchy hw asus --help' never matched a usage prefix. Strip trailing --help/-h/'?' tokens before that lookup so the prefix help lists the input/output/asus commands, matching the bare-prefix form. Guard the direct-route prefix special case against treating '?' as a prefix word.
[Low impact] The follow-up changes appear safe to merge. SummaryThe CLI now shows matching commands when a multi-word prefix ends in
Reviews (2) · Last reviewed commit: "Add CLI regression tests for multi-word ..." · Reviewed by Greptile |
|
Codex High read the diff, PR discussion, and repository guidance at |
|
GPT-6 High in Codex read the updated diff and discussion at |
|
The prefix help bug here is real: on What this one does beyond that fix: it makes a literal This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. |
Running
omarchy audio ?inbin/omarchyprints "Unknown Omarchy command: omarchy audio ?" and suggests running that same unrunnable form again, whileomarchy audio input --helpand other multi-word prefixes are likewise rejected instead of listing their commands.Screenshots
Reproduce
omarchy audio ?and press Enter.More cases
omarchy audio input --helpomarchy audio output --helpomarchy hw asus --helpRelated
bin/omarchy