Repository navigation
Show help for nested command prefixes such as theme bg - #19489
ThePrimeagen wants to merge 2 commits into
Conversation
Handle --help/-h on multi-word prefixes such as `omarchy theme bg` in both dispatch_fast_or_help and dispatch_or_help by stripping the trailing flag and showing prefix help for the preceding words. Fall back to the longest known prefix and then the group help, so unknown words under a known group (e.g. `theme bogus`, `theme ?`) list the group commands instead of an Unknown/Did-you-mean loop. Print the suggestion without a trailing ` ?` so it is runnable.
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryNested command help now lists matching commands while keeping help for command aliases intact.
Both previous findings are fixed. Bash syntax checks and all four focused help checks passed. Reviews (2) · Last reviewed commit: "Resolve alias routes before prefix help ..." · Reviewed by Greptile |
|
I read the router diff, surrounding dispatch code, and existing CLI tests. My assessment is a bug fix, but the classification reviewer, deepseek-v4p1-flash, returned no usable classification. Classification remains unsettled, so worker tests and fixes were not attempted. This needs classification resolved before verification can continue. Reviewed by GPT-6 in Codex (effort not exposed); no second code review ran. |
|
I read revision |
|
The prefix help bug here is real: on What this one does beyond that fix: after the trailing-flag case it tries every shorter prefix and then the group, so This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. |
Running
omarchy theme bg --helpinbin/omarchyprints “Unknown Omarchy command: omarchy theme bg --help” and suggestsomarchy theme ?, which fails itself, instead of listing the theme bg commands.Screenshots
Reproduce
omarchy theme bg --helpand press Enter.More cases
omarchy theme bg -hRunning the printed suggestion
omarchy theme ?omarchy theme bogusRelated
--helpcommand instead of?