Repository navigation
Show prefix help for shared commands with --help and suggest runnable commands - #19495
ThePrimeagen wants to merge 2 commits into
Conversation
Strip --help/-h (before --) from the args before calling show_prefix_help in dispatch_or_help, so a shared prefix such as "hyprland workspace layout --help" matches usages under that prefix and shows prefix help instead of Unknown. Also drop the literal trailing " ?" from the "Did you mean" suggestion, which no code treats as a help token, so the suggestion is a real runnable group command (e.g. "omarchy hyprland") instead of looping on the unknown "omarchy hyprland ?".
[Medium impact] The PR appears safe to merge. SummaryThe PR fixes help for shared command prefixes and removes the trailing
The previous coverage finding is addressed. Focused command checks and Bash syntax checks passed; the full suite was not run. No new issues found. Reviews (2) · Last reviewed commit: "Add CLI regression tests for shared pref..." · Reviewed by Greptile |
|
Read the diff, surrounding CLI routing and tests, comments, and the base branch’s command guide. Codex High classified this as a bug, but the configured classification model, deepseek-v4p1-flash, returned no usable classification, so classification remains unsettled. No labels or code changes were made, and no worker tests or second-opinion code review ran. This is waiting for classification to be resolved before verification can continue. |
|
Read the regression tests added at |
|
The prefix help bug here is real: on What this one does beyond that fix: it drops the This pull request was read, not run. Reviewed by Claude Fable 5.2; the comparison of all ten diffs also went to Opus 5.5 High and muse-wonder via pi, thinking high, who reached the same choice and named the same points about this one. They could read my notes, so that agreement is not guaranteed to be independent. Nothing was pushed here. It is waiting on the maintainer, who decides whether to keep it open. |
In
bin/omarchy, runningomarchy hyprland workspace layout --helpprintsUnknown Omarchy command: omarchy hyprland workspace layout --helpand suggestsomarchy hyprland ?instead of listing the layout commands. Running that suggestion fails the same way, so the printed suggestion can never succeed.Screenshots
Reproduce
omarchy hyprland workspace layout --helpand press Enter.Unknown Omarchy command: omarchy hyprland workspace layout --helpwithDid you mean: omarchy hyprland ?instead of the layout help listing current, default and toggle.More cases
Re-running the printed suggestion
Another shared prefix with --help
Unknown command under a known group
Related
omarchy <group> ?suggestion for unknown commands