Repository navigation
Keep the lock blank from turning the display off (DPMS link-drop crash) - #6642
akashgagda wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds configurable lock-screen DPMS blanking to prevent monitor disconnects and shell crashes.
Changes:
- Adds
lock.displayBlank, defaulting totrue. - Skips display blanking when disabled while preserving keyboard blanking.
- Documents the configuration and failure mode.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
shell/shell.qml |
Adds the built-in default. |
shell/plugins/lock/Service.qml |
Applies the option during lock blanking. |
docs/omarchy-shell.md |
Documents configuration behavior. |
config/omarchy/shell.json |
Adds the fresh-install default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Process { | ||
| id: blankProcess | ||
| command: ["bash", "-c", "omarchy-brightness-keyboard off; omarchy-brightness-display off"] | ||
| command: ["bash", "-c", root.displayBlank ? "omarchy-brightness-keyboard off; omarchy-brightness-display off" : "omarchy-brightness-keyboard off"] |
|
Don't like the idea of this being configurable. We need to find a solution that just works. Too esoteric to find this. |
e27d320 to
5b3a7a8
Compare
|
Agreed — that's why I reworked this. The configurable flag is gone; the PR now unconditionally drops the DPMS display-off from the lock blank. The root cause is The reworked blank dims only the keyboard backlight. The lock surface already covers the desktop (blurred wallpaper + password field), real display-off still happens at suspend / lid-close via Verified live: with the DPMS off removed the connector never drops — 0 disconnects, 0 DPMS events, and the shell held a secure session lock well past the former 5s blank on the very monitor that normally disconnects. Keeping that single line out of the blank avoids the crash entirely, no per-hardware opt-in. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
shell/plugins/lock/Service.qml:376
- This removes display blanking for every user rather than making it configurable. No
lock.displayBlankkey is added anywhere in the repository, and this service never readsshell.shellConfig, so the documented default oftruecannot preserve existing behavior and setting the option has no effect. Please add the default/builtin config and select this command based onlock.displayBlank, defaulting to display blanking when the key is absent.
command: ["bash", "-c", "omarchy-brightness-keyboard off"]
|
Confirmed the same failure on NVIDIA RTX 3070 with nvidia-open 610.57.04, Hyprland 0.56.2, and quickshell-git 0.3.0.r20. Four crashes followed the identical sequence: DPMS leaves no outputs, lock surfaces lose their Wayland output, EGL creation fails, and Omarchy Shell exits 255. Applied this PR's keyboard-only blank through a cloned lock plugin; it loaded successfully and avoids the triggering DPMS dispatch. Tested by GPT-5.4 via Codex. GPT 5.4 is just a Sol seizure, dont mind me |
|
Follow-up after testing on the NVIDIA system: removing display DPMS is not a complete fix because it regresses the expected screen-off behavior. I reverted that workaround and tested a narrower fix against the exact installed Quickshell revision ( The output-removal path in this->surfaces.remove(screen);
auto* window = surface->disownWindow();
window->destroy();
window->deleteLater();
surface->deleteLater();Validation on RTX 3070 / nvidia-open 610.57.04 / Hyprland 0.56.2 / Qt 6.11.1:
This appears to belong in Quickshell rather than Omarchy. Quickshell explicitly disallows AI-authored code PRs, so I have not opened one there. I recommend not merging the global DPMS removal in this PR. Investigated by GPT-5.4 via Codex. |
|
Confirmed the same lock/DPMS output-removal sequence on a QXL guest, with a more severe recovery path than a transient physical-monitor link drop. System: Omarchy 4.0.1-1, Hyprland 0.56.2-1, Quickshell 0.3.1-1, Red Hat QXL Two independent boots recorded the same timing: That 7–8 second interval lines up with the lock service's 5-second blank timer followed by As a local diagnostic mitigation I intercepted only the DPMS-disable dispatch while passing every other This confirms QXL as another affected output-removal path. It does not resolve the design question raised above: suppressing display-off avoids the trigger, while the immediate window/resource destruction in Quickshell would preserve normal DPMS behavior and address the unsafe output lifecycle directly. |
|
Confirmed on a current Quattro desktop: Omarchy 4.0.3-1, Hyprland 0.56.2-2, Quickshell 0.3.1, NVIDIA RTX 4070 SUPER, and one active LG ultrawide on DisplayPort ( With the HDMI TV disabled, This makes |
|
Reviewed at 5b3a7a8, against What ran. A worker VM (virtio GPU, Hyprland 0.56.2, Quickshell 0.3.1). On Findings
Second opinion. Codex Medium reviewed the same diff and base. It agreed with the first two findings and the comment placement (independence isn't guaranteed). It found the video poster flicker on its own, and it pointed out that unplugging a monitor while locked still goes through the same output-removal path, so this change doesn't make docking or hot-unplug safe. Related. This follows up #6628. The same crash is reported in #7478, #12079, #12208 and #9843. #11072 tries a configurable version of the same approach and is marked by its author as needing rework for the same reason. The Quickshell |
|
Tested this branch's change on Omarchy (Hyprland, NVIDIA 610.57.04, dual HDMI-A-1/A-2) — same setup as #14368. Applied the equivalent locally by cloning the lock plugin ( Result: Second confirmation for NVIDIA HDMI, as requested. 👍 |
|
Second confirmation on NVIDIA HDMI: here the same lock-blank -> Note for the branch: on Hyprland 0.56.2 the blank path in |
|
Confirming this on a second machine, with measurements before and after. Setup: Omarchy 4.5.0-3, Hyprland 0.56.2, quickshell 0.3.2.r7.g2b4501a-1, AMD Phoenix1 iGPU, a single monitor on HDMI-A-1 (ODA 2468FZV). The monitor drops its HDMI link on DPMS off. Without the change: 5 s after locking,
With the same effect as this diff (a local For comparison, #18495 (filtering FALLBACK screens) does not stop this loop on this machine: 2 exits with status 255 in 2 minutes locked with it applied. This PR removes the trigger itself. One note: the description mentions a Tested with help from Claude Code (Opus 5.5). |
|
Rechecked unchanged head The CLI suite and seven focused lock/sleep/monitor test files passed. Two further files stopped because the worker lacks Node, with the same result on the base. The configured Opus 5.5 High second review could not run because its weekly limit was reached; The earlier video-wallpaper finding no longer applies to current @SiriusRak's new AMD/HDMI measurements support suppressing the DPMS trigger, but an equivalent local override does not confirm this exact head. @akashgagda or a maintainer, please confirm repeated lock/wake/unlock cycles with |
Summary
Follow-up to #6628 / #6630. The lock screen blanks the display after locking via
hyprctl dpms disable, and on some monitors (notably over HDMI) DPMS-off makes the connector physically drop — aquamarine tears the output down under the lock surface, Quickshell hits an EGL fatal (Could not create EGL surface … Invalid argument) and the whole shell exits while still holding ext-session-lock, forcing a reboot.This ships the DPMS-off workaround as a config option rather than a hardcoded change:
lock.displayBlank(defaulttrue= unchanged behavior).falsekeeps the keyboard blank but skips the display off.Verified live on an affected system (Lenovo L24q over HDMI, i915): with
lock.displayBlank: false, a full lock → blank-window → unlock cycle produces 0 connector disconnects and the shell survives (previously a reproducible DPMS drop + crash every lock).Scope
The root cause is upstream (Hyprland/aquamarine escalating DPMS-off into a full disconnect; Quickshell qFataling on lock-surface output loss — quickshell #61/#76 family).
allow_session_lock_restore+ journal-persisted shell log + dead-lock restart recovery are handled by #6630. This PR is the omarchy-owned user-facing mitigation so affected setups stop forcing reboots.Notes
shell.jsonis canonical with no deep-merge, so a config lacking thelockkey keeps thetruedefault (verified against the QML resolution).