Repository navigation
Add Cursor Agent as a default coding agent - #6969
davydotcom wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Cursor Agent as a default coding agent, including installation, launching, menu integration, usage reporting, icons, documentation, migrations, and tests.
Changes:
- Adds Cursor Agent selection, installation, launch flags, and migration support.
- Adds Cursor usage collection and agents-panel integration.
- Adds Cursor branding, documentation, and test coverage.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 10 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
bin/omarchy-agent |
Launches Cursor Agent with unattended flags. |
bin/omarchy-agent-usage-cursor |
Collects Cursor limits and usage statistics. |
bin/omarchy-default-agent |
Adds Cursor selection and mise package mapping. |
bin/omarchy-remove-preinstalls |
Removes the Cursor lazy stub. |
default/fonts/omarchy/README.md |
Documents the Cursor glyph. |
default/omarchy/omarchy-menu.jsonc |
Adds Cursor to the agent menu. |
install/user/mise.sh |
Creates the Cursor mise wrapper. |
manual/17-ai.md |
Documents Cursor Agent and usage support. |
migrations/1786797150.sh |
Adds the wrapper for existing installations. |
shell/plugins/agents/README.md |
Documents Cursor usage collection. |
shell/plugins/agents/assets/cursor-light.svg |
Adds the dark Cursor mark. |
shell/plugins/agents/assets/cursor.svg |
Adds the light Cursor mark. |
shell/plugins/agents/manifest.json |
Enables Cursor in panel defaults. |
test/shell.d/agent-usage-cursor-scanner-test.sh |
Tests Cursor usage collection. |
test/shell.d/default-agent-test.sh |
Tests Cursor installation and launching. |
test/shell.d/menu-test.sh |
Tests Cursor menu and glyph integration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }) | ||
| assert abs(fallback[0]["percent"] - 0.25) < 1e-6, fallback | ||
|
|
||
| record = scanner.scan("test-token", scanner.API_BASE_URL, force=True, limits_only=False) |
2078453 to
5566230
Compare
|
Thanks for taking the full slice (picker, launch flags, menu glyph, usage collector, tests). First Omarchy comment from me. I am a fan and a heavy Cursor user, and I want this to ship. One piece I would not merge. Please drop omarchy-default-agent, install/user/mise.sh, and the migration all install Cursor through that plugin. It is a one-commit, 0-star asdf repo with no Cursor or Omarchy ownership. First launch (and the stub on existing installs) runs that repo’s bash: scrape cursor.com/install for a version, then curl | tar with no checksum. mise treats new asdf plugins as a legacy/untrusted path. If the repo goes away or the install-page HTML changes, everyone who picks Cursor, or just got the stub, fails to install. It also ignores a working official CLI. The gate is mise where asdf:…. I already have /opt/cursor-agent/cursor-agent on PATH. Selecting Cursor still tries the plugin, and if that fails the default is never written. Suggested replacement
The rest can stay. Storing cursor-agent and launching with Follow-up, not a blocker: the collector does not page GetFilteredUsageEvents and only reads ~/.config/cursor/auth.json (IDE sign-in is in state.vscdb). #7087 already covers both. |
|
Thanks @shawnmarck — that review was right, and the asdf plugin is gone. Cursor Agent now prefers a real The leftover asdf stub is no longer created on setup. The migration only removes one if it is already there, and Remove Preinstalls no longer deletes a user-installed The usage-collector follow-ups (paging |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 18 changed files in this pull request and generated no new comments.
Suppressed comments (1)
default/omarchy/omarchy-menu.jsonc:142
- The required running-UI verification remains unchecked in the test plan. This change adds a new menu-font glyph and a default-enabled panel provider with light/dark marks, so verify both the picker and agents panel in the running shell and inspect glyph rendering, contrast, spacing, and layout before merge.
"setup.default.agent.cursor-agent": {"icon":"","iconFont":"omarchy","label":"Cursor","checked":"[[ \"$(omarchy-default-agent)\" == \"cursor-agent\" ]]","action":"omarchy-default-agent cursor-agent"},
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The asdf plugin was a one-commit third-party scrape with no checksum, so prefer an existing cursor-agent and otherwise fetch Cursor's published linux package as cursor-agent. Co-authored-by: Cursor <cursoragent@cursor.com>
25a0dba to
733b245
Compare
|
Automated duplication check: this pull request looks similar to #8450, which covers the same Cursor default agent support. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference. |
Summary
cursor/cursor-agent) to the default-agent picker, launcher, menu, and agents-bar usage collectorcursor-agentis already on PATH, selecting Cursor writes the default and launches it (--yolo --trust)downloads.cursor.comand install it ascursor-agent(notagent)asdf:icholy/asdf-cursor-agent(third-party scrape, no checksum)Test plan
OMARCHY_PATH=$PWD ./test/shell.d/default-agent-test.shOMARCHY_PATH=$PWD ./test/shell.d/install-cursor-agent-test.shOMARCHY_PATH=$PWD ./test/shell.d/menu-test.shOMARCHY_PATH=$PWD ./test/shell.d/agent-usage-cursor-scanner-test.shcursor-agentis already on PATH and confirm it launches with--yolo --trustwithout misecursor-agent, then launched with--yolo --trust~/.local/bin/cursor-agentomarchy agent usage-update cursorand open the agents bar panel; confirm Included/Auto/API meters match Cursor's own usage UI