Skip to content

Fix Voxtype GPU setup failing silently - #7129

Closed
sgruendel wants to merge 5 commits into
omacom:quattrofrom
sgruendel:voxtype-vulkan
Closed

sgruendel wants to merge 5 commits into
omacom:quattrofrom
sgruendel:voxtype-vulkan

Conversation

@sgruendel

Copy link
Copy Markdown
Contributor

Fixes #7099

Copilot AI balanced review requested due to automatic review settings August 16, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Voxtype GPU setup permissions for new and existing installations.

Changes:

  • Runs GPU setup with sudo.
  • Adds a migration to repair CPU backend symlinks and restart Voxtype.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
bin/omarchy-voxtype-install Elevates GPU backend setup.
migrations/1786873661.sh Repairs affected existing installations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread migrations/1786873661.sh Resolved
Copilot AI review requested due to automatic review settings August 16, 2026 11:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@chessing234

Copy link
Copy Markdown
Contributor

hey, this is already covered in #12901 (voxtype gpu via sudo). mind closing this as a duplicate?

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for tracking this down, @sgruendel. The cause is right: voxtype setup gpu --enable has to rewrite the root-owned /usr/bin/voxtype, so as the user it fails, and || true hid the failure. Adding sudo is the correct fix for the installer.

#12901 fixes the same bug in the installer and handles the failure case differently, so the two compete. This review weighed them against each other, and #12901 is the one recommended to the maintainer:

  • The migration can put people back into a crash loop. migrations/1786873661.sh enables Vulkan on every install whose /usr/bin/voxtype points at voxtype-avx2 or voxtype-avx512 on a machine where omarchy-hw-vulkan succeeds. But that is also where sudo voxtype setup gpu --disable leaves a machine: upstream's disable() switches back to the best CPU binary. The migration can't tell a machine this bug left on CPU from one a person put there on purpose. The main reason to do that on purpose is Voxtype install enables Vulkan on Haswell (hasvk) GPUs, causing an endless SIGABRT crash loop #11370: Intel Haswell GPUs (hasvk) advertise Vulkan, but voxtype-vulkan aborts on every model load, and the service restarts it every five seconds. Anyone who applied that workaround would have Vulkan switched back on by this migration and their service restarted straight into the loop. omarchy-hw-vulkan only checks that an ICD file exists, so it doesn't prevent this.
  • A failed GPU step now stops the whole install. Under set -e, a declined sudo prompt or a failed sudo voxtype setup gpu --enable at bin/omarchy-voxtype-install:19 exits before voxtype setup systemd. Dictation that would have worked on CPU is left half set up. Enable Voxtype GPU backend through sudo #12901 warns and carries on.

Whether existing installs should be repaired by a migration at all is the maintainer's decision. Doing it safely would take the Haswell detection from #11481 at minimum, and still couldn't recognise a deliberate CPU choice. Neither point is patched here, because the fix for the first one is a design choice rather than a defect.

What was checked: the diff, the base installer, voxtype's upstream src/setup/gpu.rs for what --enable and --disable point the symlink at, #7099, #11110, #11370, #11481 and #12901. Nothing was run on a worker. The fix recommended for merging is #12901, so this branch was compared rather than tested. The second opinion, Codex Medium, was asked which pull request to pick without being given this review's answer, although the brief did point it at the migration and at set -e. It also picked #12901 and found the same two problems here, and its independence from this review isn't guaranteed. It also noted that #7129's test only covers the migration, so reverting the installer change leaves it green.

This is waiting on the maintainer to choose between #7129 and #12901.

@omarchybot

Copy link
Copy Markdown
Collaborator

Thank you for this, @sgruendel. #12901 fixes the same problem in a way the review judged better, so this is closed in favour of it. If it does not cover your case, please say so there.

Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent.

@omarchybot omarchybot closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Voxtype does not symlink to voxtype-vulkan on Vulkan enabled system

4 participants