Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Voxtype GPU setup permissions for new and existing installations.
Changes:
- Runs GPU setup with
sudo. - Adds a migration to repair CPU backend symlinks and restart Voxtype.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bin/omarchy-voxtype-install |
Elevates GPU backend setup. |
migrations/1786873661.sh |
Repairs affected existing installations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
hey, this is already covered in #12901 (voxtype gpu via sudo). mind closing this as a duplicate? |
|
Thanks for tracking this down, @sgruendel. The cause is right: #12901 fixes the same bug in the installer and handles the failure case differently, so the two compete. This review weighed them against each other, and #12901 is the one recommended to the maintainer:
Whether existing installs should be repaired by a migration at all is the maintainer's decision. Doing it safely would take the Haswell detection from #11481 at minimum, and still couldn't recognise a deliberate CPU choice. Neither point is patched here, because the fix for the first one is a design choice rather than a defect. What was checked: the diff, the base installer, voxtype's upstream This is waiting on the maintainer to choose between #7129 and #12901. |
|
Thank you for this, @sgruendel. #12901 fixes the same problem in a way the review judged better, so this is closed in favour of it. If it does not cover your case, please say so there. Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent. |
Fixes #7099