Repository navigation
Honor OMARCHY_SCREENRECORD_USE_PORTAL when recording fullscreen - #7188
Conversation
The portal backend is the opt-in path for HDR, external-GPU monitors and window capture, but --fullscreen was matched first and passed the focused monitor straight to the kms backend, so the variable never applied there. On a hybrid-GPU laptop the kms backend only enumerates the connectors of the single DRM card it attaches to, so a monitor driven by the other GPU is not visible to it and recording fails. That left no configuration in which ALT + PRINT could record such a monitor, even though the portal backend handles it fine. Check the variable first so it applies to every capture path.
|
Reviewed, and nothing found wrong with the change. The bug is real on What was checked. This head merged onto current Second opinion. Codex (medium effort) reviewed the same merged tree and found no defect; it agreed with the reproduction, and since it can read this session's reasoning, its agreement is not guaranteed independent. It also checked the webcam overlay with a One correction to the description. On current This covers the second half of #7184; the silent failure it also describes is #7189, so this one is not marked as closing the issue. Nothing is needed from you: it is waiting on the maintainer. |
|
Closing: this worked around gpu-screen-recorder failing to find an external monitor wired to the other GPU on hybrid laptops, by retrying through the desktop portal. gpu-screen-recorder 6.1.0 and later fix that at the cause by capturing through the GPU the monitor is connected to, and every Omarchy channel now ships 6.1.4 or newer; the portal retry also fails on these same machines (xdg-desktop-portal-hyprland #420). If recording an external monitor still fails after updating, please open a new issue with the gpu-screen-recorder error line. Thanks for working on it. |
|
Reopening: I closed this by mistake. It is not a portal retry workaround; it makes the documented OMARCHY_SCREENRECORD_USE_PORTAL opt-in apply to fullscreen recordings (Alt+Print), which today ignore it because the --fullscreen branch is checked first. That is worth fixing on its own, whether or not the hybrid-GPU monitor bug is gone in gpu-screen-recorder 6.1.x. Sorry for the noise. |
[Medium impact] The change appears safe to merge. Summary
Reviews (1) · Last reviewed commit: "Honor OMARCHY_SCREENRECORD_USE_PORTAL wh..." · Reviewed by Greptile |
The header of
omarchy-capture-screenrecordingdocuments the portal backend as the opt-in path for "HDR-aware capture, support for monitors driven by external GPUs, and window capture", and the comment right above the branch repeats it. But--fullscreenis matched first and passes the focused monitor straight to the kms backend, soOMARCHY_SCREENRECORD_USE_PORTAL=truenever applies on that path.That matters on hybrid-GPU laptops. The kms backend attaches to one DRM card and only enumerates that card's connectors, so a monitor driven by the other GPU is invisible to it:
Since
ALT + PRINTpasses--fullscreen, there was no configuration in which it could record that monitor — even with the variable set, and even though the portal backend records it fine.Checking the variable first makes it apply to every capture path. No change for anyone who doesn't set it.
Reported in #7184.