Skip to content

Honor OMARCHY_SCREENRECORD_USE_PORTAL when recording fullscreen - #7188

Merged
dhh merged 1 commit into
omacom:quattrofrom
Literato2:honor-portal-with-fullscreen
Nov 16, 2026
Merged

dhh merged 1 commit into
omacom:quattrofrom
Literato2:honor-portal-with-fullscreen

Conversation

@Literato2

Copy link
Copy Markdown
Contributor

The header of omarchy-capture-screenrecording documents the portal backend as the opt-in path for "HDR-aware capture, support for monitors driven by external GPUs, and window capture", and the comment right above the branch repeats it. But --fullscreen is matched first and passes the focused monitor straight to the kms backend, so OMARCHY_SCREENRECORD_USE_PORTAL=true never applies on that path.

That matters on hybrid-GPU laptops. The kms backend attaches to one DRM card and only enumerates that card's connectors, so a monitor driven by the other GPU is invisible to it:

$ gpu-screen-recorder --list-capture-options
eDP-1|1920x1080     # Intel, card2
region
portal              # no HDMI-A-1 — that's on the NVIDIA card1
gsr error: display "HDMI-A-1" not found, expected one of:
  "screen"
  "eDP-1"    (1920x1080+1920+0)

Since ALT + PRINT passes --fullscreen, there was no configuration in which it could record that monitor — even with the variable set, and even though the portal backend records it fine.

Checking the variable first makes it apply to every capture path. No change for anyone who doesn't set it.

Reported in #7184.

The portal backend is the opt-in path for HDR, external-GPU monitors and
window capture, but --fullscreen was matched first and passed the focused
monitor straight to the kms backend, so the variable never applied there.

On a hybrid-GPU laptop the kms backend only enumerates the connectors of
the single DRM card it attaches to, so a monitor driven by the other GPU
is not visible to it and recording fails. That left no configuration in
which ALT + PRINT could record such a monitor, even though the portal
backend handles it fine.

Check the variable first so it applies to every capture path.
@omarchybot omarchybot added bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review and removed bug Something isn't working labels Sep 27, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed, and nothing found wrong with the change. The bug is real on quattro independent of hardware: --fullscreen is matched before OMARCHY_SCREENRECORD_USE_PORTAL, so the documented opt-in never reaches that path.

What was checked. This head merged onto current quattro (3faafba), run on a disposable Omarchy worker with gpu-screen-recorder stubbed to record its arguments. OMARCHY_SCREENRECORD_USE_PORTAL=true omarchy-capture-screenrecording --fullscreen passes -w DP-1 on quattro, -w portal with this change, and -w DP-1 again with it reverted. Without the variable (or with it false), --fullscreen still records the focused monitor through kms, so nobody who has not opted in sees a difference. test/shell.d/screenrecording-test.sh passes (26/26). ./test/cli has one failure, vscode generated theme references current theme file, which fails identically on plain quattro and is unrelated to this change. The fix to the NVIDIA-driven monitor itself was not reproduced, since a worker has one virtual GPU; what was proved is that the variable now selects the portal backend on this path.

Second opinion. Codex (medium effort) reviewed the same merged tree and found no defect; it agreed with the reproduction, and since it can read this session's reasoning, its agreement is not guaranteed independent. It also checked the webcam overlay with a portal target (the resizer already handles portal recordings) and found no caller that needs --fullscreen to override the opt-in.

One correction to the description. On current quattro, ALT + PRINT opens the capture menu (default/hypr/bindings/utilities.lua:39), and none of the menu's recording entries pass --fullscreen. So this fixes explicit --fullscreen invocations (omarchy screenrecord --fullscreen), not the default keybinding flow.

This covers the second half of #7184; the silent failure it also describes is #7189, so this one is not marked as closing the issue. Nothing is needed from you: it is waiting on the maintainer.

@omarchybot

Copy link
Copy Markdown
Collaborator

Closing: this worked around gpu-screen-recorder failing to find an external monitor wired to the other GPU on hybrid laptops, by retrying through the desktop portal. gpu-screen-recorder 6.1.0 and later fix that at the cause by capturing through the GPU the monitor is connected to, and every Omarchy channel now ships 6.1.4 or newer; the portal retry also fails on these same machines (xdg-desktop-portal-hyprland #420). If recording an external monitor still fails after updating, please open a new issue with the gpu-screen-recorder error line. Thanks for working on it.

@omarchybot omarchybot closed this Nov 16, 2026
@omarchybot omarchybot reopened this Nov 16, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reopening: I closed this by mistake. It is not a portal retry workaround; it makes the documented OMARCHY_SCREENRECORD_USE_PORTAL opt-in apply to fullscreen recordings (Alt+Print), which today ignore it because the --fullscreen branch is checked first. That is worth fixing on its own, whether or not the hybrid-GPU monitor bug is gone in gpu-screen-recorder 6.1.x. Sorry for the noise.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The change appears safe to merge.

Summary

OMARCHY_SCREENRECORD_USE_PORTAL=true now takes priority over --fullscreen, as intended by Literato2.

  • Fullscreen recordings now honor the portal setting.

Reviews (1) · Last reviewed commit: "Honor OMARCHY_SCREENRECORD_USE_PORTAL wh..." · Reviewed by Greptile

@dhh
dhh merged commit 263c3bd into omacom:quattro Nov 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants