Repository navigation
Conversation
…Hyprland binds Hyprland can't fire a release-bind for a lone modifier key like Right Cmd/Super (hyprwm/Hyprland#6946), so o.bind can't be used to rebind voxtype's push-to-talk to a bare modifier. Point to voxtype's own built-in evdev hotkey as the working alternative.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds guidance for configuring voxtype push-to-talk on a bare modifier key by using voxtype’s evdev hotkey instead of Hyprland keybinds.
Changes:
- Document Hyprland’s limitation with release-binds on lone modifier keys (with upstream issue link).
- Provide an alternative configuration path via
~/.config/voxtype/config.tomlhotkey settings.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for digging into this. I checked the new comment against a stock Omarchy install, and one part of it doesn't hold: Hyprland 0.56.2 can do hold-to-talk on a bare modifier key, as long as the release bind is written a particular way. What I ran: an Omarchy ISO worker with Hyprland 0.56.2. I added binds with
The voxtype half is correct.
Second opinion: Codex Medium reviewed the diff, the voxtype docs and the worker results above. It agreed the comment is wrong as written, and it raised the daemon restart. It was working from the same evidence I was, so its agreement is not independent. Next: this is waiting on you. If you want to keep the note, the accurate version would say the release bind needs |
Summary
o.bind/bindrpair — Hyprland never fires the release-bind for a lone modifier key (hyprwm/Hyprland#6946, still open as of Hyprland 0.56.2).Test plan
./test/all— 3 pre-existing unrelated failures (need a separateomarchy-pkgscheckout), reproduced identically with this change stashed outdefault/hypr/bindings/voxtype.lua, no behavior change