Skip to content

Note that voxtype push-to-talk can't be rebound to a bare modifier key - #7302

Open
doctor wants to merge 1 commit into
omacom:quattrofrom
doctor:add-voxtype-modifier-hold-note
Open

doctor wants to merge 1 commit into
omacom:quattrofrom
doctor:add-voxtype-modifier-hold-note

Conversation

@doctor

@doctor doctor commented Aug 17, 2026

Copy link
Copy Markdown

Summary

  • Right Cmd/Super (or any bare modifier key, either side) can't do hold/release push-to-talk via a Hyprland o.bind/bindr pair — Hyprland never fires the release-bind for a lone modifier key (hyprwm/Hyprland#6946, still open as of Hyprland 0.56.2).
  • Confirmed by testing plain keysym binds, the documented "modifier tap" pattern, and raw keycode binds — all fire on press, none fire on release.
  • voxtype has its own built-in evdev hotkey listener that grabs the key directly and isn't affected, so this adds a short comment pointing users who want this at that instead of leading them into the same dead end.

Test plan

  • ./test/all — 3 pre-existing unrelated failures (need a separate omarchy-pkgs checkout), reproduced identically with this change stashed out
  • Comment-only change to default/hypr/bindings/voxtype.lua, no behavior change

…Hyprland binds

Hyprland can't fire a release-bind for a lone modifier key like Right
Cmd/Super (hyprwm/Hyprland#6946), so o.bind can't be used to rebind
voxtype's push-to-talk to a bare modifier. Point to voxtype's own
built-in evdev hotkey as the working alternative.
Copilot AI balanced review requested due to automatic review settings August 17, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds guidance for configuring voxtype push-to-talk on a bare modifier key by using voxtype’s evdev hotkey instead of Hyprland keybinds.

Changes:

  • Document Hyprland’s limitation with release-binds on lone modifier keys (with upstream issue link).
  • Provide an alternative configuration path via ~/.config/voxtype/config.toml hotkey settings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for digging into this. I checked the new comment against a stock Omarchy install, and one part of it doesn't hold: Hyprland 0.56.2 can do hold-to-talk on a bare modifier key, as long as the release bind is written a particular way.

What I ran: an Omarchy ISO worker with Hyprland 0.56.2. I added binds with hyprctl eval, sent real key events through a uinput device (ydotool), and pressed and released Right Super twice per case. An F10 press/release pair fired correctly as a control.

  • Super_R press + Super_R with { release = true }: only the press fires. This matches what you saw.
  • Super_R press + Super_R with { release = true, ignore_mods = true }: press and release both fire, every time.
  • SUPER + Super_R for both binds, release with { release = true }: press and release both fire, every time.

o.bind passes its options straight to hl.bind, so something like o.bind("Super_R", "Stop dictation (push-to-talk)", "voxtype record stop", { release = true, ignore_mods = true }) works. That means the line saying o.bind can't do this (default/hypr/bindings/voxtype.lua:2-3) would send people away from a bind that works. hyprwm/Hyprland#6946 was closed as fixed in July 2024, and the fix's own thread gives the SUPER + Super_R form as the one that works.

The voxtype half is correct. [hotkey] enabled = true with key = "RIGHTMETA" is valid per voxtype's configuration reference, and the input group access it needs is already granted by install/hardware/input-group.sh. voxtype doesn't reload its config while running, so after editing the file you have to run systemctl --user restart voxtype.

./test/cli and the Hyprland config, binding-conflict and voxtype shell tests pass on the worker. Nothing in them depends on a comment.

Second opinion: Codex Medium reviewed the diff, the voxtype docs and the worker results above. It agreed the comment is wrong as written, and it raised the daemon restart. It was working from the same evidence I was, so its agreement is not independent.

Next: this is waiting on you. If you want to keep the note, the accurate version would say the release bind needs ignore_mods = true (or SUPER + Super_R) and mention voxtype's evdev hotkey as an alternative. #13486 also changes the F9 release bind in this file, so the two will need to be reconciled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants