Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Clarifies that the end-user Omarchy skill supports reporting and diagnosis, not upstream source development.
Changes:
- Adds explicit scope boundaries against unsolicited source changes.
- Removes fork, clone, push, and PR instructions.
- Reframes contributing guidance around reports and suggestions.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
default/agents/skills/omarchy/SKILL.md |
Updates the contributing topic description. |
default/agents/skills/omarchy/contributing.md |
Adds scope guards and removes source-development workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
f12962c to
6c54a8f
Compare
6c54a8f to
33a2f53
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
default/agents/skills/omarchy/SKILL.md:49
- The new upstream-fix route remains unreachable for a direct implementation request: this same skill still says “Do NOT use this skill for Omarchy development tasks” (line 37), its frontmatter excludes source development (lines 10–11), and line 82 again declares development out of scope. An agent following those higher-level loading rules will not load
contributing.md, so it never sees the new checkout and publishing approval gates. Make explicit reporting/suggestion/upstream-fix requests exceptions to the skill exclusion, while continuing to defer actual source-tree conventions to the repository instructions.
- [`contributing.md`](contributing.md) - reporting Omarchy bugs and, when explicitly requested, submitting fixes upstream
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33a2f53413
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
default/agents/skills/omarchy/SKILL.md:49
- This link does not actually route explicit upstream-fix requests through this guide. The same skill still says it is not for contributing to source code (lines 18–19), instructs agents not to use it for development tasks (line 37), and repeats that such requests are out of scope (line 82); the frontmatter also only describes end-user customization. An agent handling an upstream-fix request will therefore be told not to load the skill before it can discover this link. Please update the skill’s activation/scope guidance to include diagnosis, reporting, suggestions, and explicit upstream-fix requests while retaining the approval gates in
contributing.md.
- [`contributing.md`](contributing.md) - diagnosing or reporting Omarchy bugs and, when explicitly requested, submitting fixes upstream
OldJobobo
left a comment
There was a problem hiding this comment.
Ready for review
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ff874856f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The gate allowed source changes only for an explicit upstream fix. With the skill now invoked for more than end-user requests, someone already in an Omarchy checkout asking for a feature would be refused or asked again despite having asked for the work. Gate on an explicit request to change Omarchy, and say that diagnosing, reporting, or customizing is not one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Reviewed as a documentation change by Claude Opus 5.5, with Codex Medium as a second opinion over four rounds. Only Markdown changed, so nothing was run: the review read the text against the repository at the head. The things it names hold up: I pushed one commit, 2322fb9. Codex found that the gate let an agent do source work only for an explicit upstream fix. Because the skill is no longer limited to end-user requests, it would now load for someone already working in an Omarchy checkout, and it would refuse or second-guess a feature they had explicitly asked for. The commit changes the frontmatter exclusion, both gates in One thing for the maintainer: #6718 rewrites the same skill much more broadly, including its reporting and upstream handoff, so whichever lands second will need rebasing. This is now waiting on the maintainer's decision. |
quattro (omacom#5925) removed the body's "When This Skill MUST Be Used" list in favour of the frontmatter, which collided with this branch's additions to that list. The resolution keeps quattro's frontmatter and section removal, adds this branch's diagnosing, reporting and explicit-contribution triggers to the frontmatter, and carries the "diagnosing, reporting, or customizing is not that request" clause into Source Development Scope so the gate it described is not lost with the section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge. SummaryAdds explicit approval steps to the installed Omarchy agent guidance.
No actionable issues found. Reviews (2) · Last reviewed commit: "Merge quattro into guard-agent-upstream-..." · Reviewed by Greptile |
|
This stopped merging cleanly after #5925 landed on Only Markdown changed, so nothing was run. I re-read both files against the tree at the new head. The frontmatter still parses as YAML. It now merges cleanly into |
quattro now documents the diagnostics command as omarchy-debug, because the omarchy router cannot find it on a package install (omacom#13817), and that rewrote the comment this branch had put the upload approval on. Keep the approval gate and name the command the way quattro does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
This stopped merging cleanly again after #13817 landed on Only Markdown changed, so nothing was run. I re-read both files against the tree at the new head: It merges cleanly into |
Problem
The globally installed Omarchy skill says source development is out of scope, but its contribution workflow can still be read as permission to leave an unrelated project, create an Omarchy checkout, and begin implementing a fix after diagnosing or reporting a bug.
A request to diagnose or report an Omarchy bug should not imply permission to implement it upstream. Likewise, preparing a fix should not imply permission to push it or open a PR.
Change
Preserve the existing reporting and PR guidance while adding explicit scope gates:
Validation
git diff --check./test/allwas started but not completed because the full suite was too resource-intensive for the active system. Before it was stopped, it reached an environment-dependent, unrelated failure requiring a separateomarchy-pkgscheckout. This change only touches Markdown agent guidance.