Repository navigation
Fix shell restart race through launcher ownership - #7546
Draft
Skeptomenos wants to merge 1 commit into
Draft
Skeptomenos wants to merge 1 commit into
Skeptomenos wants to merge 1 commit into
Conversation
This was referenced Oct 2, 2026
Collaborator
|
Following the merge of #11015, The five-second slow-exit race is covered, but this PR changes supervisor ownership to handle crashes/overlapping children during teardown. That distinct lifecycle change is not in the merged performance fix; keep it open for its remaining scope. Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-launch-shellsupervisor before launching a replacementquickshell killbehaviorRoot cause
omarchy-restart-shellrepeatedly calledquickshell killuntil no instance matched. Stock Quickshell 0.3 returns before QML teardown is complete. Its development fix waits for IPC disconnect, but disconnect is still not a process-ownership boundary.A second stop request or replacement launch can therefore overlap teardown. On an ARM system this produced a Quickshell
SIGSEGVduringomarchy update. The surviving supervisor relaunched its child while the update launched another supervisor, which left two shells and two bars.The launcher already owns the child lifecycle and waits for the child it terminates. This change uses that ownership boundary directly.
This addresses the restart race described in #7076. It does not claim to fix the separate cold QML compilation and readiness concerns in that issue.
Validation
./test/all: all 184 current test files passedbin/omarchy commands --check: 428 commands passed