Repository navigation
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed. Nothing wrong with it — this does exactly what the description says, and it ships as-is as far as I can tell. Verified end to end on a disposable Arch VM (pacman 7.1.0, libalpm 16.0.1) with
Three things the fix rests on, which I checked rather than assumed:
One consequence worth stating plainly, more for the maintainer than for you:
A second opinion from codex at xhigh agreed with all of the above; its independence is not currently guaranteed, so read that as agreement rather than confirmation. It did raise one thing I had not looked at, which is pre-existing and not yours to fix: this script never checks pacman's exit status and has no Waiting on the maintainer from here. |
…n any locale pacman prints its 'up to date -- reinstalling' warning in the user's locale, but the grep filter that hides it only matches the English string. With LANG=sv_SE.UTF-8 the message leaked through on every update. Force LC_ALL=C on the archlinux-keyring install so the message is always English and the filter suppresses it.
1069340 to
ef20486
Compare
The reinstall now runs as sudo env LC_ALL=C pacman, so the sudo stub matched nothing on it: the assertion on the exact reinstall command failed, and a failing reinstall could no longer be simulated. The stub now looks past env and its assignments, and the assertion requires LC_ALL=C, so the locale pin is covered rather than only tolerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-reviewed after the rebase onto What was wrong. The test's Verified on a disposable Omarchy worker (pacman 7.1.0) with
Codex at medium effort reviewed the script change and the test fix (read-only) and found nothing to change. It agreed with the points above; its independence from this review is not guaranteed. For the maintainer: #13362 rewrites the same line of |
quattro now reinstalls every signing keyring the machine trusts in one pacman call (Arch Linux ARM's and a platform's list beside Arch's), with a filter matching any keyring's reinstall warning. That filter is English-only like the one it replaced, so the pin moves onto the new call, and the new test cases expect it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] This PR appears safe to merge. SummaryPins pacman's locale with
Reviews (4) · Last reviewed commit: "Merge quattro to keep the locale pin bes..." · Reviewed by Greptile |
|
Re-reviewed after What I pushed. 5612106 merges What was checked, on a disposable Omarchy worker (pacman 7.1.0) with
Second opinion. Codex Medium reviewed the merged head and found no defects: it confirmed the merge keeps all of Nothing is left for you; this waits on the maintainer. |
quattro now refreshes the keyrings with --needed, so a current keyring prints "is up to date -- skipping" rather than "-- reinstalling". That notice is localized just the same, so the English-only filter still leaks it on a non-English system: the C locale goes on the new command, and the tests expect it there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-reviewed after Pushed to your branch: 1050796 merges Checked on a disposable Omarchy worker with Second opinion: Codex Medium reviewed the merge and found nothing to change. It confirmed nothing from Nothing is left for you to do. This now waits on the maintainer. |
…otstrap quattro now bootstraps and checks Arch Linux ARM's signing key before the keyring refresh (omacom#14820), and its new test cases assert the unpinned refresh command. Strip sudo env in the stub before the new gpg/pacman-key dispatch, and expect LC_ALL=C in the two new refresh assertions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-reviewed after Pushed to your branch: 781510f merges Checked on a disposable Omarchy worker (pacman 7.1.0) with
Second opinion: Codex Medium reviewed the merge read-only and found nothing to change. It confirmed that nothing from Nothing is left for you to do. This waits on the maintainer. |
quattro now refreshes omarchy-keyring with the Arch keyrings (omacom#17311) and adds Arch Linux ARM's key from a shipped copy rather than a keyserver (omacom#18508). Both rewrote the lines around the refresh, so the branch no longer merged. The refresh keeps quattro's command and heading and still runs as sudo env LC_ALL=C pacman, and every refresh assertion quattro changed expects the C locale. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Re-reviewed after Pushed to your branch: e43b79a merges Checked on a disposable Omarchy worker (pacman 7.1.0), running the real script under
Second opinion: Codex Medium and muse-wonder (thinking high) each reviewed the merge read-only and found nothing to change. Both confirmed that nothing from Other pull requests for the same bug: #18620 and #18634, both opened on 12 November, make the same one-line change to the refresh. Both reviewers were asked which of the three should go forward, without being given an answer, and both named this one: it is the oldest, and neither newer one handles a case this one misses. #18620 does not update the test, which fails with its change. #18634's test differs only in exporting the One thing for you, @fldc, if you have a minute: the description's The code needs nothing more from you. This waits on the maintainer. |
Summary
This fixes a minor update annoyance of mine. :D
omarchy-update-keyringre-installsarchlinux-keyringon every update and pipes the output through agrep -vEfilter that hides pacman's "up to date -- reinstalling" warning.That filter only matches the English string, but pacman prints the message in the user's locale. On a Swedish system (
LANG=sv_SE.UTF-8) the warning leaked through on every update, producing noise even on a clean, successful run.Fix
Force
LC_ALL=Con thearchlinux-keyringinstall so pacman's messages are always English and the existing filter reliably suppresses the warning, regardless of the user's locale.Fixes #18477