Repository navigation
Conversation
|
Reviewed. The opt-in gating is correct — nothing enables this without an explicit toggle — but the mechanism does not appear to fix the bug the PR names, and your own docs PR #7631 says so. The rule does not address the failure mode. The mechanism reads as borrowed from #7044, but that PR fixes a genuinely different failure: an Intel TB3 controller that runtime-suspends into D3cold after an unplug and never re-enumerates. Detection gate and rule disagree on scope. Line 15 gates on eight hardcoded device IDs while the rule matches by PCI class and claims in its comment to cover "all current and future AMD xHCI device IDs". All eight are real AMD xHCI parts, but the list omits many — Reported state can diverge from actual state, in both directions. The menu entry is not hardware-gated. Two smaller ones. Base branch. This targets On #7631. It should land separately, and it can land first. It is self-contained, it names the actual root cause, and it is close to what was asked for on #6671. If this PR lands as written, #7631's text and this toggle contradict each other and the manual would need an edit in the same change. What was checked. The CLI suite on a disposable VM: A second opinion from Nothing was pushed to your branch — the open questions here are yours and the maintainer's to settle, not something a reviewer should patch around. Waiting on you for the mechanism question and the base branch; waiting on the maintainer for whether a menu toggle is wanted at all, given the ask on #6671 was to document instead. |
|
Thank you for this incredibly detailed and instructive review! You are entirely correct on all counts. The fundamental flaw here was conflating runtime power management ( Additionally, the insights regarding the Given that #7631 accurately identifies the root cause and provides the actual working fix, I am closing this PR to avoid shipping a placebo mechanism. We will let the documentation PR stand as the definitive solution for this bug. Thanks again for taking the time to write such a comprehensive technical teardown! |
Opt-in udev rule behind
omarchy toggle amd-xhci-wakeup; keeps AMD xHCI controllers awake so the broken suspend→resume path (Bugzilla 221073, Ubuntu 2158539) never runs; off by default honoring #6671 (dhh: default-on raises laptop power draw; he asked to document instead — docs side lives in #7631); class-based match (0x0c0330 + vendor 0x1022) avoids device-ID whack-a-mole; sibling of #7044 (same power/control=on + d3cold_allowed=0 for the Intel TB3 xHCI).