Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an AVX2 compatibility gate to prevent installing an unusable Voxtype binary.
Changes:
- Rejects unsupported CPUs before prompting or downloading.
- Tests both incompatible and AVX2-capable flows.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-voxtype-install |
Adds the AVX2 capability check and error. |
test/shell.d/voxtype-install-test.sh |
Covers rejection and successful setup paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
voxtype-bin 1.1.0 ships a baseline CPU build and selects it when /proc/cpuinfo has no avx2, so refusing the whole install now blocks machines Voxtype runs on. The one step that still lands them on an AVX2-only binary is `voxtype setup gpu --enable`, which switches to the Vulkan build without checking the CPU; only take it when the CPU has AVX2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @kx0101. Since this was opened, the ground under it moved, so I pushed a change on top (c91a6f1) that narrows the guard rather than refusing the install. What changed underneath. What is still broken on The change. The early exit is gone; the Vulkan step is taken only when the CPU has AVX2 ( Reviewed by Claude Opus 5.5, with a second opinion from Codex Medium on c91a6f1: it found no defect in the installer or the test and agreed the Vulkan step is the one to guard. That agreement is with conclusions already written down, so its independence is not guaranteed. It could not fetch the package itself; the package contents above were checked separately on the worker. The title and description still describe rejecting the install, so they are worth updating to match. This now waits on the maintainer. |
|
This branch no longer merges into What I got wrong. I said the installer's Where the guard matters. It matters once something elevates that step. #12901 changes it to Reviewed by Claude Opus 5.5, with a second opinion from Codex Medium. Codex read |
Closes #7883
Checks for AVX2 before showing the confirmation or downloading Voxtype and its model. CPUs that cannot execute the packaged
voxtype-avx2binary now receive a clear error instead of reachingvoxtype setupand failing with SIGILL.The regression test runs the real installer with simulated CPU capabilities and verifies both paths:
Tests:
bash test/shell.d/voxtype-install-test.shbash -n bin/omarchy-voxtype-install test/shell.d/voxtype-install-test.sh