Repository navigation
Conversation
Every sibling indicator acts on its mode when clicked; the dictation glyph instead opened the Voxtype config for both buttons, leaving no way to start dictation from the bar. Left click now toggles dictation, the same action as the SUPER+CTRL+X binding, and right click keeps opening the config TUI. Closes omacom#7900.
There was a problem hiding this comment.
Pull request overview
Updates the dictation indicator to toggle recording on left click while preserving configuration access on right click.
Changes:
- Dispatches dictation actions based on mouse button.
- Updates indicator contract assertions for both actions.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
shell/plugins/bar/indicators/Dictation.qml |
Adds button-specific dictation behavior. |
test/shell.d/fixtures/indicator-contract/shell.qml |
Verifies left- and right-click commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Left click toggles dictation, matching the SUPER+CTRL+X binding and the | ||
| // toggle-on-click behavior of every sibling indicator. Any other button | ||
| // opens the Voxtype config TUI. |
|
Confirmed on Omarchy 4.0.0-1: left/right click on the dictation glyph both open |
|
yeah
thanks!
…On Mon, Aug 24, 2026 at 8:18 AM CDRZ ***@***.***> wrote:
*thecdrz* left a comment (omacom/omarchy#7905)
<#7905 (comment)>
Confirmed on Omarchy 4.0.0-1: left/right click on the dictation glyph both
open omarchy-voxtype-config, while SUPER+CTRL+X / F9 toggle correctly.
The left=voxtype record toggle / right=config split matches the other
indicators and the manual. Looks good to merge from here.
—
Reply to this email directly, view it on GitHub
<#7905>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEMTED6YZNL6KI4JYHXESNL5LPCKXAVCNFSNUABFKJSXA33TNF2G64TZHM4TSNBQHEZTCNRWHNEXG43VMU5TKMRSG42TKMJQGY42C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BEMTEDZBSC4OQTBQCEDW7SL5LPCKXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZZGA4DMOJQG43KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BEMTED3XZMQQHHD6LG5R5HT5LPCKXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZZGA4DMOJQG43KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tahadx
left a comment
There was a problem hiding this comment.
Reviewer disclosure: this review was written by an AI coding assistant (ox-alpha) at the contributor's request, and posted with their approval. Please weigh it alongside human review.
What I checked
I verified the plumbing behind the change: WidgetButton.qml declares signal pressed(int button) and triggerPress(button) re-emits it, so onPressed: function(button) receives the real button and the Qt.LeftButton discrimination is sound rather than relying on incidental behavior. Left click matching the existing SUPER+CTRL+X binding and the toggle-on-click convention of every sibling indicator (Dnd, NightLight, StayAwake, ScreenRecording) makes this the consistent shape for the cluster.
Observations
- Updating the fixture mattered more than it looks: the old indicator-contract fixture asserted two clicks → two config runs, i.e. it had codified the bug. The new assertions cover all three failure modes: exactly one toggle command on left press, exactly one config command on right press, zero model commands from either.
- Keeping config on right-click preserves one-click settings access instead of forcing users through a menu — good call over dropping it entirely.
- Minor: "any other button opens the config" means middle-click gets the TUI too; for a two-action glyph that seems fine, just noting the code implements exactly what the comment says.
Small diff, correct convention alignment, contract tests updated to match reality rather than the bug. Nothing further from me.
tahadx
left a comment
There was a problem hiding this comment.
Reviewer disclosure: this review was written by an AI assistant at the contributor's request and posted with their approval. I am an AI, not a human reviewer — please weigh it alongside human review.
Rich code review — #7905 (dictation indicator toggles on left click)
Making the left click toggle dictation (matching the SUPER+CTRL+X binding and sibling indicators) and routing other buttons to the Voxtype config is consistent and user-friendly.
Verified
onPressed: function(button)correctly branches onQt.LeftButton.- The indicator-contract test is updated to assert exactly one
voxtype record toggle(left) and oneomarchy-voxtype-config(right), and zeroomarchy-voxtype-model. voxtype record toggleis the same subcommand the keybinding uses — verified present in the codebase.
One thing to double check (non-blocking)
If the user has toggled dictation while the bar is hidden or during a race with the voxtype service starting, a left click could silently no-op. That's inherent to the toggle design and not a regression of this PR.
Verdict: ship.
Closes #7900.
What
The dictation glyph sat in the hover cluster acting like a toggle but opened the Voxtype config TUI on both left and right click — the only indicator of the six that didn't act on its own mode, and it left no way to start dictation from the bar at all.
voxtype record toggle— the exact action of the existingSUPER+CTRL+Xbinding (default/hypr/bindings/voxtype.lua)omarchy-voxtype-configWhy this shape
The manual describes these glyphs as status modes, and every sibling (
Dnd,NightLight,StayAwake,ScreenRecording) flips its mode on press. Keeping config on right-click preserves one-click access to settings without breaking the cluster's convention.Tests
Updated
test/shell.d/fixtures/indicator-contract/shell.qml, which previously codified the old behavior (asserting two clicks produced two config runs). It now asserts:voxtype record toggleomarchy-voxtype-configomarchy-voxtype-modelcommand from eitherindicator-contract-test.sh,voxtype-invitation-test.sh, and the binding-conflict tests pass; full./test/shellshows only the three pre-existing environmental failures from a missing localomarchy-pkgscheckout.