Repository navigation
Conversation
a2171bd to
d659aef
Compare
d659aef to
bae9ffe
Compare
|
Reviewed at bae9ffe, and the fix works. On a worker built from the Omarchy ISO, I ran my own reproduction with a This had no second opinion. The configured reviewer (Codex Medium) was reachable, but its review budget for the day was used up, so this is one model's review. #9124 makes the same change to One interaction for whichever lands: #8534 changes this script's Waiting on the maintainer. |
Summary
Closes #7852
Reproduction
The installer previously had no fail-fast mode. If
omarchy-pkg-add,sudo systemctl, orsudo usermodreturned nonzero, execution continued and could still print:The regression test reproduces this without installing NordVPN or invoking privileges. Before the fix, a stubbed package failure still reached every later step, the success message, reboot prompt, and reboot command, and the script exited successfully.
The installer now uses the same
set -ebehavior as comparable Omarchy installers. A required command failure stops the script at that command, and an interruption status of 130 is preserved.Tests
bash -n bin/omarchy-install-service-nordvpn test/shell.d/nordvpn-install-test.shbash test/shell.d/nordvpn-install-test.sh./test/all— all 199 test files passed./bin/omarchy commands --check— all 434 command metadata checks passedgit diff --cached --check