Repository navigation
Conversation
UWSM owns that target. Requires=/Wants= from a linger or Persistent user unit starts an empty session and Hyprland never launches.
There was a problem hiding this comment.
Pull request overview
Adds agent guidance preventing user units from pulling UWSM’s graphical session target.
Changes:
- Expands skill triggers for user units, timers, and linger.
- Adds systemd user-unit safety guidance.
- Recommends post-boot hooks for desktop automation.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
default/agents/skills/omarchy/user-units.md |
Documents safe user-unit patterns. |
default/agents/skills/omarchy/SKILL.md |
Adds triggers, routing, and safety warnings. |
default/agents/skills/omarchy/hooks.md |
Directs post-desktop automation to hooks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| UWSM owns `graphical-session.target`. Omarchy's shipped user units under | ||
| `$OMARCHY_PATH/default/systemd/user/` start *with* that target via | ||
| `WantedBy=graphical-session.target`. They never `Requires=` or `Wants=` it. |
| After editing units: `systemctl --user daemon-reload`. Then | ||
| `systemctl --user show graphical-session.target -p RequiredBy` must not | ||
| list the job. |
A unit with Wants=graphical-session.target shows up in the target's WantedBy, not its RequiredBy, so the check passed the very dependency the guide forbids. Units that only name the target in [Install] WantedBy= appear in the target's Wants instead, so WantedBy stays empty on a stock install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed by Claude Opus 5.5. This is Markdown only, so nothing was run; it was checked by reading every claim against What holds up:
One fix pushed to your branch (c5710d9): the closing check in Overlap: #6718 rewrites the same No second opinion ran: the configured reviewer (Codex Medium) had used up its daily review quota, so this has been checked by one model only. It waits on that review, and then on the maintainer. |
omarchy-recover-internal-monitor.service has to run before the session and is WantedBy=graphical-session-pre.target, so "the shipped units start with graphical-session.target" was not true of all of them. What holds for every one is that none Requires= or Wants= it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A unit enabled to start at boot under linger pulls the session target again on the next boot, so the reboot only helped when the trigger had already been consumed, as with the Persistent timer in the reproduction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
The second opinion has now run. Codex Medium reviewed the change against Two wording fixes were pushed to your branch:
On its second round Codex found nothing more. It agreed that the shipped-unit pattern, This is labelled |
|
| After editing units: `systemctl --user daemon-reload`. Then | ||
| `systemctl --user show graphical-session.target -p RequiredBy -p WantedBy` | ||
| must not list the job. |
There was a problem hiding this comment.
Dependency check can miss jobs
After daemon-reload, this check can pass even if a newly written job has Requires=graphical-session.target or Wants=graphical-session.target: a job that has not been loaded may not appear in the target’s RequiredBy or WantedBy properties. That gives users false reassurance before the job’s first start, when it could start the target early and prevent UWSM from launching Hyprland. Please check the job’s own dependencies too.
omacom#5925 removed the skill body's "When This Skill MUST Be Used" list and moved its triggers into the frontmatter, where this branch had also added its own. Keep quattro's frontmatter and add this branch's systemd user unit path and triggers to it; the user-unit bullet this branch had added to the removed list goes with it, since the frontmatter now carries the same triggers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comments Outside DiffThese findings could not be posted inline.
|
|
This stopped merging cleanly after #5925 landed on I checked the guidance again against current This is now waiting on the maintainer. |
Why
UWSM owns
graphical-session.target. Omarchy's shipped user units already start with that target (WantedBy=) and neverRequires=orWants=it.Agents following generic systemd GUI examples write
Requires=graphical-session.target. That starts the target. If the user manager is already up (linger, a Persistent timer, an SSH session), UWSM printsA compositor or graphical-session* target is already active!and refuses to start Hyprland. Plymouth has quit; the screens stay black until the next boot.The installed agent skill did not mention this, and its triggers did not include
~/.config/systemd/user/, so the skill often never loaded for that work.What
user-units.md, copying the pattern from$OMARCHY_PATH/default/systemd/user/omarchy hook install post-bootinstead of pulling the session targetReproduced with linger + a Persistent user timer +
Requires=graphical-session.target: UWSM helper exits 1,Welcome to Hyprlandnever appears. An immediate reboot (timer already consumed) starts normally.This is additive against current quattro. #6718 rewrites the skill more broadly; happy to rebase or fold into that if preferred.