Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Updates clipboard-history paste behavior to use terminal-aware shortcuts.
Changes:
- Uses Shift+Insert for terminals and Ctrl+V elsewhere.
- Adds terminal/non-terminal text-helper tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-clipboard-paste-text |
Adds adaptive paste shortcut selection. |
bin/omarchy-clipboard-paste-file |
Applies adaptive shortcuts to file pasting. |
test/shell.d/clipboard-test.sh |
Tests text pasting by focused window type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Clipboard history always sent Shift+Insert, which Electron and browser windows ignore, so selecting an entry copied it but never pasted it. Universal paste already splits on the terminal tag in default/hypr/bindings/clipboard.lua; the paste helpers now do the same. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2a95bac to
d2a5642
Compare
quattro renamed the tensaku-edit test stub to omasnap on the same chmod line this branch adds the hyprctl stub to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Universal paste on quattro now sends Ctrl+Shift+V to terminals, so the helpers no longer share its split; keep Shift+Insert for terminals and say why instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed by Claude Opus 5.5. The second opinion (Codex Medium) did not run on this pull request: the reviewer answered a ping, but its daily review budget was spent, so this is one model's reading. Could not reproduce the bug on a stock install. On a worker VM built from the Omarchy ISO, running current
The Ctrl+V branch also pastes correctly, so the change does no harm there. But a fix is only worth merging against a bug somebody has seen, and on a stock install this one did not show. @fregys, which application and browser does nothing on Shift+Insert for you — Firefox or Zen, a particular Electron app, or a particular site's editor? The exact app and version, and the steps, are what would let this be reproduced. Pushed to your branch:
On the worker, Related: #12377 makes the same change (Ctrl+V outside terminals, through Hyprland Waiting on the author for a reproduction; no |
Selecting an entry from clipboard history always sends
Shift+Insert. That keystroke is handled by each client application rather than by the compositor, so it is inconsistent across GUI apps — in a browser window nothing pastes at all. The entry lands on the clipboard but never reaches the window, so you have to press Ctrl+V yourself. In a terminal it works, which is why it looks intermittent rather than broken.Omarchy already solves this for universal paste in
default/hypr/bindings/clipboard.lua:Ctrl+V for normal windows, Shift+Insert for terminals, off the
terminaltag fromdefault/hypr/apps/terminals.lua. The clipboard paste helpers just don't follow that rule. This makes them follow it — terminals keep Shift+Insert, everything else gets Ctrl+V.Same fix in
omarchy-clipboard-paste-textandomarchy-clipboard-paste-file. The inline-text path still types instead of pasting, unchanged.Checked on 4.0.1 with different text in the clipboard and in the primary selection:
wtype -M shift -k Insert -m shiftpastes nothing into a browser window. I've been running the Ctrl+V half locally since 4.0 and it pastes correctly there and in Electron apps.test/shell.d/clipboard-test.shnow stubshyprctland covers both branches../test/shelland./test/clipass.